From: Conor Dooley <conor@kernel.org>
To: Hui Wang <hui.wang@canonical.com>
Cc: linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
hvilleneuve@dimonoff.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andy@kernel.org,
lech.perczak@camlingroup.com, Maarten.Brock@sttls.nl
Subject: Re: [PATCH v3 1/2] dt-bindings: serial: sc16is7xx: add reset-gpios
Date: Wed, 12 Jun 2024 17:37:30 +0100 [thread overview]
Message-ID: <20240612-skeleton-bullseye-71067b2244b4@spud> (raw)
In-Reply-To: <20240612131454.49671-1-hui.wang@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 522 bytes --]
On Wed, Jun 12, 2024 at 09:14:53PM +0800, Hui Wang wrote:
> In some designs, the chip reset pin is connected to a GPIO, and this
> GPIO needs to be set correctly before probing the driver, so add a
> reset-gpios in the device tree.
>
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> ---
> In the v3:
> - drop the Reviewed-by
> - change gpio to GPIO
> - change "this GPIO" to "and this GPIO"
> - change "so adding" to "so add"
There's no need to drop an R-b for grammar changes in a commit message.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-06-12 16:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 13:14 [PATCH v3 1/2] dt-bindings: serial: sc16is7xx: add reset-gpios Hui Wang
2024-06-12 13:14 ` [PATCH v3 2/2] serial: sc16is7xx: hardware reset chip if reset-gpios is defined in DT Hui Wang
2024-06-12 13:50 ` Hugo Villeneuve
2024-06-12 14:46 ` Hui Wang
2024-06-12 13:56 ` Lech Perczak
2024-06-12 14:50 ` Hui Wang
2024-06-13 20:45 ` Andy Shevchenko
2024-06-12 16:37 ` Conor Dooley [this message]
2024-06-12 16:49 ` [PATCH v3 1/2] dt-bindings: serial: sc16is7xx: add reset-gpios Hugo Villeneuve
2024-06-12 16:58 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240612-skeleton-bullseye-71067b2244b4@spud \
--to=conor@kernel.org \
--cc=Maarten.Brock@sttls.nl \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hui.wang@canonical.com \
--cc=hvilleneuve@dimonoff.com \
--cc=jirislaby@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lech.perczak@camlingroup.com \
--cc=linux-serial@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox