Linux Serial subsystem development
 help / color / mirror / Atom feed
From: Hui Wang <hui.wang@canonical.com>
To: linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
	gregkh@linuxfoundation.org
Cc: jirislaby@kernel.org, hvilleneuve@dimonoff.com, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, andy@kernel.org,
	lech.perczak@camlingroup.com, Maarten.Brock@sttls.nl,
	hui.wang@canonical.com
Subject: [PATCH v3 1/2] dt-bindings: serial: sc16is7xx: add reset-gpios
Date: Wed, 12 Jun 2024 21:14:53 +0800	[thread overview]
Message-ID: <20240612131454.49671-1-hui.wang@canonical.com> (raw)

In some designs, the chip reset pin is connected to a GPIO, and this
GPIO needs to be set correctly before probing the driver, so add a
reset-gpios in the device tree.

Signed-off-by: Hui Wang <hui.wang@canonical.com>
---
In the v3:
 - drop the Reviewed-by
 - change gpio to GPIO
 - change "this GPIO" to "and this GPIO"
 - change "so adding" to "so add"

 Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
index 5dec15b7e7c3..88871480018e 100644
--- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
+++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
@@ -28,6 +28,9 @@ properties:
   clocks:
     maxItems: 1
 
+  reset-gpios:
+    maxItems: 1
+
   clock-frequency:
     description:
       When there is no clock provider visible to the platform, this
@@ -91,6 +94,7 @@ unevaluatedProperties: false
 examples:
   - |
     #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/gpio/gpio.h>
     i2c {
         #address-cells = <1>;
         #size-cells = <0>;
@@ -120,6 +124,7 @@ examples:
             compatible = "nxp,sc16is752";
             reg = <0x54>;
             clocks = <&clk20m>;
+            reset-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
             interrupt-parent = <&gpio3>;
             interrupts = <7 IRQ_TYPE_EDGE_FALLING>;
             nxp,modem-control-line-ports = <0 1>; /* Ports 0 and 1 as modem control lines */
-- 
2.34.1


             reply	other threads:[~2024-06-12 13:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-12 13:14 Hui Wang [this message]
2024-06-12 13:14 ` [PATCH v3 2/2] serial: sc16is7xx: hardware reset chip if reset-gpios is defined in DT Hui Wang
2024-06-12 13:50   ` Hugo Villeneuve
2024-06-12 14:46     ` Hui Wang
2024-06-12 13:56   ` Lech Perczak
2024-06-12 14:50     ` Hui Wang
2024-06-13 20:45     ` Andy Shevchenko
2024-06-12 16:37 ` [PATCH v3 1/2] dt-bindings: serial: sc16is7xx: add reset-gpios Conor Dooley
2024-06-12 16:49   ` Hugo Villeneuve
2024-06-12 16:58     ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240612131454.49671-1-hui.wang@canonical.com \
    --to=hui.wang@canonical.com \
    --cc=Maarten.Brock@sttls.nl \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hvilleneuve@dimonoff.com \
    --cc=jirislaby@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lech.perczak@camlingroup.com \
    --cc=linux-serial@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox