Re: [PATCH v3 1/2] dt-bindings: serial: sc16is7xx: add reset-gpios

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]

On Wed, Jun 12, 2024 at 12:49:43PM -0400, Hugo Villeneuve wrote:
> On Wed, 12 Jun 2024 17:37:30 +0100
> Conor Dooley <conor@kernel.org> wrote:
> 
> > On Wed, Jun 12, 2024 at 09:14:53PM +0800, Hui Wang wrote:
> > > In some designs, the chip reset pin is connected to a GPIO, and this
> > > GPIO needs to be set correctly before probing the driver, so add a
> > > reset-gpios in the device tree.
> > > 
> > > Signed-off-by: Hui Wang <hui.wang@canonical.com>
> > > ---
> > > In the v3:
> > >  - drop the Reviewed-by
> > >  - change gpio to GPIO
> > >  - change "this GPIO" to "and this GPIO"
> > >  - change "so adding" to "so add"
> > 
> > There's no need to drop an R-b for grammar changes in a commit message.
> 
> Hi Conor,
> The R-b tags were never given in the first place, that is why they are
> removed:
> 
> https://lore.kernel.org/all/6b1b0635-304c-48d7-a941-fae30962083a@canonical.com/

lmao, yea that's justified (and probably should've been mentioned).

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]