[PATCH] serial: jsm: fix NPE during jsm_uart_port_init

[PATCH] serial: jsm: fix NPE during jsm_uart_port_init

[Dustin Lundquist]

No driver was set which caused serial_base_ctrl_add to crash.

Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to enable runtime PM")
Signed-off-by: Dustin Lundquist <dustin@null-ptr.net>
---
drivers/tty/serial/jsm/jsm_tty.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/jsm/jsm_tty.c b/drivers/tty/serial/jsm/jsm_tty.c
index ce0fef7e2c66..be2f130696b3 100644
--- a/drivers/tty/serial/jsm/jsm_tty.c
+++ b/drivers/tty/serial/jsm/jsm_tty.c
@@ -451,6 +451,7 @@ int jsm_uart_port_init(struct jsm_board *brd)
		if (!brd->channels[i])
			continue;

+		brd->channels[i]->uart_port.dev = &brd->pci_dev->dev;
		brd->channels[i]->uart_port.irq = brd->irq;
		brd->channels[i]->uart_port.uartclk = 14745600;
		brd->channels[i]->uart_port.type = PORT_JSM;
-- 
2.47.2

Re: [PATCH] serial: jsm: fix NPE during jsm_uart_port_init

[Greg KH]

On Mon, May 05, 2025 at 11:18:34AM -0700, Dustin Lundquist wrote:
> No driver was set which caused serial_base_ctrl_add to crash.
> 
> Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to enable runtime PM")
> Signed-off-by: Dustin Lundquist <dustin@null-ptr.net>
> ---
> drivers/tty/serial/jsm/jsm_tty.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tty/serial/jsm/jsm_tty.c b/drivers/tty/serial/jsm/jsm_tty.c
> index ce0fef7e2c66..be2f130696b3 100644
> --- a/drivers/tty/serial/jsm/jsm_tty.c
> +++ b/drivers/tty/serial/jsm/jsm_tty.c
> @@ -451,6 +451,7 @@ int jsm_uart_port_init(struct jsm_board *brd)
> 		if (!brd->channels[i])
> 			continue;
> 
> +		brd->channels[i]->uart_port.dev = &brd->pci_dev->dev;
> 		brd->channels[i]->uart_port.irq = brd->irq;
> 		brd->channels[i]->uart_port.uartclk = 14745600;
> 		brd->channels[i]->uart_port.type = PORT_JSM;
> -- 
> 2.47.2

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You have marked a patch with a "Fixes:" tag for a commit that is in an
  older released kernel, yet you do not have a cc: stable line in the
  signed-off-by area at all, which means that the patch will not be
  applied to any older kernel releases.  To properly fix this, please
  follow the documented rules in the
  Documentation/process/stable-kernel-rules.rst file for how to resolve
  this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot