* [PATCH] serial: 8250_mid: Add missing module namespace import for SERIAL_8250
@ 2026-09-26 23:01 Nathan Chancellor
2026-09-26 23:06 ` sashiko-bot
2026-09-28 8:17 ` Andy Shevchenko
0 siblings, 2 replies; 3+ messages in thread
From: Nathan Chancellor @ 2026-09-26 23:01 UTC (permalink / raw)
To: Andy Shevchenko, Greg Kroah-Hartman, Jiri Slaby
Cc: Tate Whiteberg, linux-kernel, linux-serial, Nathan Chancellor
After commit 1c305d5f1daa ("serial: 8250_mid: wait for LSR tx empty
before setting termios"), modpost errors (or warning with
CONFIG_MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS=y):
ERROR: modpost: drivers/tty/serial/8250/8250_mid.ko: module uses symbol 'serial8250_wait_for_xmitr' from namespace 'SERIAL_8250', but does not import it.
Add the missing module namespace import to clear up the error/warning.
Fixes: 1c305d5f1daa ("serial: 8250_mid: wait for LSR tx empty before setting termios")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
drivers/tty/serial/8250/8250_mid.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/8250/8250_mid.c b/drivers/tty/serial/8250/8250_mid.c
index c02ecb96e8b6..47f820fcd1a4 100644
--- a/drivers/tty/serial/8250/8250_mid.c
+++ b/drivers/tty/serial/8250/8250_mid.c
@@ -415,3 +415,4 @@ module_pci_driver(mid8250_pci_driver);
MODULE_AUTHOR("Intel Corporation");
MODULE_LICENSE("GPL v2");
MODULE_DESCRIPTION("Intel MID UART driver");
+MODULE_IMPORT_NS("SERIAL_8250");
---
base-commit: bf961847813d9edcb5a9c089714069428d141fa9
change-id: 20260927-tty-8250_mid-ns-import-1d83eed19a12
Best regards,
--
Cheers,
Nathan
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] serial: 8250_mid: Add missing module namespace import for SERIAL_8250
2026-09-26 23:01 [PATCH] serial: 8250_mid: Add missing module namespace import for SERIAL_8250 Nathan Chancellor
@ 2026-09-26 23:06 ` sashiko-bot
2026-09-28 8:17 ` Andy Shevchenko
1 sibling, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-09-26 23:06 UTC (permalink / raw)
To: Nathan Chancellor; +Cc: linux-serial
> After commit 1c305d5f1daa ("serial: 8250_mid: wait for LSR tx empty
> before setting termios"), modpost errors (or warning with
> CONFIG_MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS=y):
>
> ERROR: modpost: drivers/tty/serial/8250/8250_mid.ko: module uses symbol 'serial8250_wait_for_xmitr' from namespace 'SERIAL_8250', but does not import it.
>
> Add the missing module namespace import to clear up the error/warning.
>
> Fixes: 1c305d5f1daa ("serial: 8250_mid: wait for LSR tx empty before setting termios")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260927-tty-8250_mid-ns-import-v1-1-84d0482e1c5d@kernel.org?part=1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] serial: 8250_mid: Add missing module namespace import for SERIAL_8250
2026-09-26 23:01 [PATCH] serial: 8250_mid: Add missing module namespace import for SERIAL_8250 Nathan Chancellor
2026-09-26 23:06 ` sashiko-bot
@ 2026-09-28 8:17 ` Andy Shevchenko
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2026-09-28 8:17 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Andy Shevchenko, Greg Kroah-Hartman, Jiri Slaby, Tate Whiteberg,
linux-kernel, linux-serial
On Sun, Sep 27, 2026 at 01:01:17AM +0200, Nathan Chancellor wrote:
> After commit 1c305d5f1daa ("serial: 8250_mid: wait for LSR tx empty
> before setting termios"), modpost errors (or warning with
> CONFIG_MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS=y):
>
> ERROR: modpost: drivers/tty/serial/8250/8250_mid.ko: module uses symbol 'serial8250_wait_for_xmitr' from namespace 'SERIAL_8250', but does not import it.
>
> Add the missing module namespace import to clear up the error/warning.
Oh, indeed, good catch!
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-28 8:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-26 23:01 [PATCH] serial: 8250_mid: Add missing module namespace import for SERIAL_8250 Nathan Chancellor
2026-09-26 23:06 ` sashiko-bot
2026-09-28 8:17 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox