* [PATCH tty-next] serial: 8250_pci1xxxx: Disable SERIAL_8250_PCI1XXXX config by default
@ 2023-03-01 10:09 Kumaravel Thiagarajan
2023-03-01 11:25 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Kumaravel Thiagarajan @ 2023-03-01 10:09 UTC (permalink / raw)
To: gregkh
Cc: jirislaby, andriy.shevchenko, ilpo.jarvinen, deller,
geert+renesas, phil.edworthy, matthew.gerlach, linux-serial,
linux-kernel
Disable SERIAL_8250_PCI1XXXX config by default
Signed-off-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>
---
drivers/tty/serial/8250/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
index 978dc196c29b..cbf11147dc89 100644
--- a/drivers/tty/serial/8250/Kconfig
+++ b/drivers/tty/serial/8250/Kconfig
@@ -299,7 +299,6 @@ config SERIAL_8250_PCI1XXXX
tristate "Microchip 8250 based serial port"
depends on SERIAL_8250 && PCI
select SERIAL_8250_PCILIB
- default SERIAL_8250
help
Select this option if you have a setup with Microchip PCIe
Switch with serial port enabled and wish to enable 8250
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH tty-next] serial: 8250_pci1xxxx: Disable SERIAL_8250_PCI1XXXX config by default
2023-03-01 10:09 [PATCH tty-next] serial: 8250_pci1xxxx: Disable SERIAL_8250_PCI1XXXX config by default Kumaravel Thiagarajan
@ 2023-03-01 11:25 ` Greg KH
2023-03-01 15:52 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2023-03-01 11:25 UTC (permalink / raw)
To: Kumaravel Thiagarajan
Cc: jirislaby, andriy.shevchenko, ilpo.jarvinen, deller,
geert+renesas, phil.edworthy, matthew.gerlach, linux-serial,
linux-kernel
On Wed, Mar 01, 2023 at 03:39:30PM +0530, Kumaravel Thiagarajan wrote:
> Disable SERIAL_8250_PCI1XXXX config by default
Why?
Please read the kernel documentation for how to write a good changelog
text.
>
> Signed-off-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>
What commit id does this fix?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH tty-next] serial: 8250_pci1xxxx: Disable SERIAL_8250_PCI1XXXX config by default
2023-03-01 11:25 ` Greg KH
@ 2023-03-01 15:52 ` Andy Shevchenko
2023-03-02 7:03 ` Kumaravel.Thiagarajan
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2023-03-01 15:52 UTC (permalink / raw)
To: Greg KH
Cc: Kumaravel Thiagarajan, jirislaby, ilpo.jarvinen, deller,
geert+renesas, phil.edworthy, matthew.gerlach, linux-serial,
linux-kernel
On Wed, Mar 01, 2023 at 12:25:06PM +0100, Greg KH wrote:
> On Wed, Mar 01, 2023 at 03:39:30PM +0530, Kumaravel Thiagarajan wrote:
> > Disable SERIAL_8250_PCI1XXXX config by default
>
> Why?
>
> Please read the kernel documentation for how to write a good changelog
> text.
Kumaravel, hint for you: Take what Linus had written in the discussion of
Greg's pull request. It mainly explains it all.
> > Signed-off-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>
>
> What commit id does this fix?
Another hint: this lacks so called Fixes tag. You may read about it in the
documentation.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH tty-next] serial: 8250_pci1xxxx: Disable SERIAL_8250_PCI1XXXX config by default
2023-03-01 15:52 ` Andy Shevchenko
@ 2023-03-02 7:03 ` Kumaravel.Thiagarajan
0 siblings, 0 replies; 4+ messages in thread
From: Kumaravel.Thiagarajan @ 2023-03-02 7:03 UTC (permalink / raw)
To: andriy.shevchenko, gregkh
Cc: jirislaby, ilpo.jarvinen, deller, geert+renesas, phil.edworthy,
matthew.gerlach, linux-serial, linux-kernel
> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Wednesday, March 1, 2023 9:23 PM
> On Wed, Mar 01, 2023 at 12:25:06PM +0100, Greg KH wrote:
> > On Wed, Mar 01, 2023 at 03:39:30PM +0530, Kumaravel Thiagarajan wrote:
> > > Disable SERIAL_8250_PCI1XXXX config by default
> >
> > Why?
> >
> > Please read the kernel documentation for how to write a good changelog
> > text.
>
> Kumaravel, hint for you: Take what Linus had written in the discussion of
> Greg's pull request. It mainly explains it all.
Thank you, Andy. I will do this.
>
> > > Signed-off-by: Kumaravel Thiagarajan
> > > <kumaravel.thiagarajan@microchip.com>
> >
> > What commit id does this fix?
>
> Another hint: this lacks so called Fixes tag. You may read about it in the
> documentation.
Thank you for this too. I somehow missed this.
Regards,
Kumar
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-02 7:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-01 10:09 [PATCH tty-next] serial: 8250_pci1xxxx: Disable SERIAL_8250_PCI1XXXX config by default Kumaravel Thiagarajan
2023-03-01 11:25 ` Greg KH
2023-03-01 15:52 ` Andy Shevchenko
2023-03-02 7:03 ` Kumaravel.Thiagarajan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox