* [PATCH] serial: 8250_dw: Add ACPI ID for Sophgo SG2044 UART
@ 2025-03-04 7:02 Inochi Amaoto
2025-03-04 11:36 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Inochi Amaoto @ 2025-03-04 7:02 UTC (permalink / raw)
To: Ilpo Järvinen, Andy Shevchenko, Greg Kroah-Hartman,
Jiri Slaby
Cc: Inochi Amaoto, linux-kernel, linux-serial, Yixun Lan, Longbin Li
The UART on Sophgo SG2044 can be enumerated via ACPI.
Add ACPI ID for it.
Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
drivers/tty/serial/8250/8250_dw.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index 6afcf27db3b8..031ca1a7155b 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -785,6 +785,7 @@ static const struct acpi_device_id dw8250_acpi_match[] = {
{ "INT3434", (kernel_ulong_t)&dw8250_dw_apb },
{ "INT3435", (kernel_ulong_t)&dw8250_dw_apb },
{ "INTC10EE", (kernel_ulong_t)&dw8250_dw_apb },
+ { "SOPH0002", (kernel_ulong_t)&dw8250_skip_set_rate_data },
{ },
};
MODULE_DEVICE_TABLE(acpi, dw8250_acpi_match);
--
2.48.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] serial: 8250_dw: Add ACPI ID for Sophgo SG2044 UART
2025-03-04 7:02 [PATCH] serial: 8250_dw: Add ACPI ID for Sophgo SG2044 UART Inochi Amaoto
@ 2025-03-04 11:36 ` Andy Shevchenko
2025-03-04 11:48 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2025-03-04 11:36 UTC (permalink / raw)
To: Inochi Amaoto
Cc: Ilpo Järvinen, Greg Kroah-Hartman, Jiri Slaby, linux-kernel,
linux-serial, Yixun Lan, Longbin Li
On Tue, Mar 04, 2025 at 03:02:09PM +0800, Inochi Amaoto wrote:
> The UART on Sophgo SG2044 can be enumerated via ACPI.
> Add ACPI ID for it.
This is fake ACPI ID. Please work with a vendor to issue the proper one.
Vendor ACPI ID registry has no records on Sophgo:
https://uefi.org/ACPI_ID_List?acpi_search=SophGo
NAK.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] serial: 8250_dw: Add ACPI ID for Sophgo SG2044 UART
2025-03-04 11:36 ` Andy Shevchenko
@ 2025-03-04 11:48 ` Andy Shevchenko
2025-03-04 11:50 ` Inochi Amaoto
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2025-03-04 11:48 UTC (permalink / raw)
To: Inochi Amaoto
Cc: Ilpo Järvinen, Greg Kroah-Hartman, Jiri Slaby, linux-kernel,
linux-serial, Yixun Lan, Longbin Li
On Tue, Mar 04, 2025 at 01:36:47PM +0200, Andy Shevchenko wrote:
> On Tue, Mar 04, 2025 at 03:02:09PM +0800, Inochi Amaoto wrote:
> > The UART on Sophgo SG2044 can be enumerated via ACPI.
> > Add ACPI ID for it.
>
> This is fake ACPI ID. Please work with a vendor to issue the proper one.
> Vendor ACPI ID registry has no records on Sophgo:
> https://uefi.org/ACPI_ID_List?acpi_search=SophGo
>
> NAK.
FWIW, the I2C thread has more insights and details:
https://lore.kernel.org/r/20250304070212.350155-3-inochiama@gmail.com
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] serial: 8250_dw: Add ACPI ID for Sophgo SG2044 UART
2025-03-04 11:48 ` Andy Shevchenko
@ 2025-03-04 11:50 ` Inochi Amaoto
0 siblings, 0 replies; 4+ messages in thread
From: Inochi Amaoto @ 2025-03-04 11:50 UTC (permalink / raw)
To: Andy Shevchenko, Inochi Amaoto
Cc: Ilpo Järvinen, Greg Kroah-Hartman, Jiri Slaby, linux-kernel,
linux-serial, Yixun Lan, Longbin Li
On Tue, Mar 04, 2025 at 01:48:57PM +0200, Andy Shevchenko wrote:
> On Tue, Mar 04, 2025 at 01:36:47PM +0200, Andy Shevchenko wrote:
> > On Tue, Mar 04, 2025 at 03:02:09PM +0800, Inochi Amaoto wrote:
> > > The UART on Sophgo SG2044 can be enumerated via ACPI.
> > > Add ACPI ID for it.
> >
> > This is fake ACPI ID. Please work with a vendor to issue the proper one.
> > Vendor ACPI ID registry has no records on Sophgo:
> > https://uefi.org/ACPI_ID_List?acpi_search=SophGo
> >
> > NAK.
>
> FWIW, the I2C thread has more insights and details:
> https://lore.kernel.org/r/20250304070212.350155-3-inochiama@gmail.com
>
Thanks for your info, I have seen the feedback.
Regards,
Inochi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-03-04 11:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-04 7:02 [PATCH] serial: 8250_dw: Add ACPI ID for Sophgo SG2044 UART Inochi Amaoto
2025-03-04 11:36 ` Andy Shevchenko
2025-03-04 11:48 ` Andy Shevchenko
2025-03-04 11:50 ` Inochi Amaoto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox