Re: [PATCH V2] serial: exar: Preserve FCTR[5] bit in pci_xr17v35x_setup()

[andy.shevchenko@gmail.com]

Wed, Feb 21, 2024 at 09:16:46PM +0000, Matthew Howell kirjoitti:
> Allows the use of the EN485 hardware pin by preserving the value of
> FCTR[5] in pci_xr17v35x_setup().
> 
> Per the XR17V35X datasheet, the EN485 hardware pin works by setting
> FCTR[5] when the pin is active. pci_xr17v35x_setup() prevented the use
> of EN485 because it overwrote the FCTR register.

First of all, please avoid In-Reply-to: for the new versions of the change,
i.o.w. new version — new email thread.

Second, the above commit message sounds like a fix. Does it deserve Fixes tag?

...

>  	unsigned int baud = 7812500;
>  	u8 __iomem *p;
>  	int ret;
> +	u8 en485mask;

Please, preserve reversed xmas tree order.

	unsigned int baud = 7812500;
	u8 __iomem *p;
	u8 en485mask;
	int ret;

-- 
With Best Regards,
Andy Shevchenko