From: Thomas Gleixner <tglx@linutronix.de>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: Taichi Kageyama <t-kageyama@cp.jp.nec.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jiang.liu@linux.intel.com" <jiang.liu@linux.intel.com>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jslaby@suse.cz" <jslaby@suse.cz>,
"prarit@redhat.com" <prarit@redhat.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Subject: Re: [RFC PATCH v2 0/3] genirq, serial: 8250: Workaround to avoid irq=0 for console
Date: Wed, 29 Jul 2015 13:53:52 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1507291351530.3825@nanos> (raw)
In-Reply-To: <55B8BE39.6080500@hurleysoftware.com>
On Wed, 29 Jul 2015, Peter Hurley wrote:
> On 07/29/2015 06:32 AM, Thomas Gleixner wrote:
> > On Wed, 29 Jul 2015, Taichi Kageyama wrote:
> >> - Keep interrupt disabled on the CPU which is used to detect
> >> an interrupt during the timeout of autoconfig_irq().
> >> + Kick printk() on the CPU which detects interrupt
> >> from a console serial port.
> >
> > This is wrong to begin with. How is that supposed to work on an UP
> > machine? Not at all.
> >
> > So no, fix the code which has interrupts disabled accross autoprobing
> > and do not try to apply bandaids somewhere else.
>
> Like printk() from some unrelated driver?
If that's the cause for the wreckage then yes, we need a way to tell
the printk code not to call into the driver until that initialization
step is done. It's that simple.
Thanks,
tglx
next prev parent reply other threads:[~2015-07-29 11:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 8:12 [RFC PATCH v2 0/3] genirq, serial: 8250: Workaround to avoid irq=0 for console Taichi Kageyama
2015-07-29 8:12 ` [RFC PATCH v2 1/3] serial: 8250: Fix autoconfig_irq() to avoid race conditions Taichi Kageyama
2015-08-06 12:53 ` Peter Hurley
2015-07-29 8:12 ` [RFC PATCH v2 2/3] genirq: Add a function to set irq affinity of candidate IRQs Taichi Kageyama
2015-07-29 8:13 ` [RFC PATCH v2 3/3] serial: 8250: Fix autoconfig_irq() to reduce the risk of failure Taichi Kageyama
2015-07-29 10:32 ` [RFC PATCH v2 0/3] genirq, serial: 8250: Workaround to avoid irq=0 for console Thomas Gleixner
2015-07-29 11:51 ` Peter Hurley
2015-07-29 11:53 ` Thomas Gleixner [this message]
2015-07-29 13:17 ` Peter Hurley
2015-07-29 13:35 ` Thomas Gleixner
2015-07-30 1:41 ` Taichi Kageyama
2015-07-30 10:12 ` Thomas Gleixner
2015-07-30 13:43 ` Peter Hurley
2015-07-30 22:12 ` Thomas Gleixner
2015-07-30 23:43 ` Peter Hurley
2015-07-31 7:02 ` Taichi Kageyama
2015-08-02 9:52 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1507291351530.3825@nanos \
--to=tglx@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=jiang.liu@linux.intel.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=peter@hurleysoftware.com \
--cc=prarit@redhat.com \
--cc=t-kageyama@cp.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox