From: Thomas Gleixner <tglx@linutronix.de>
To: Taichi Kageyama <t-kageyama@cp.jp.nec.com>
Cc: Peter Hurley <peter@hurleysoftware.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jiang.liu@linux.intel.com" <jiang.liu@linux.intel.com>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jslaby@suse.cz" <jslaby@suse.cz>,
"prarit@redhat.com" <prarit@redhat.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [RFC PATCH v2 0/3] genirq, serial: 8250: Workaround to avoid irq=0 for console
Date: Thu, 30 Jul 2015 12:12:29 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1507301207070.3825@nanos> (raw)
In-Reply-To: <55B980E6.70800@cp.jp.nec.com>
On Thu, 30 Jul 2015, Taichi Kageyama wrote:
> On 2015/07/29 22:35, Thomas Gleixner wrote:
> I know your code is sample (console.h is required),
> but it is conflict with [patch v2 1/3].
> I think serial8250_console_write should not touch ctrl reg during autoconfig_irq.
> To resolve the real problem, I think keeping only [patch v2 1/3] is best(opt1).
> What do you think?
>
> opt1. keep [patch v2 1/3]
> + Don't touch other legacy drivers using autoprobe.
> Each driver can use console_lock to fix this problem if it happens.
No, we already know that autoprobing and console access can cause
this, so we fix it at the core code and be done with it.
Can you please test Peters patch and confirm that is solves it.
Thanks,
tglx
next prev parent reply other threads:[~2015-07-30 10:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 8:12 [RFC PATCH v2 0/3] genirq, serial: 8250: Workaround to avoid irq=0 for console Taichi Kageyama
2015-07-29 8:12 ` [RFC PATCH v2 1/3] serial: 8250: Fix autoconfig_irq() to avoid race conditions Taichi Kageyama
2015-08-06 12:53 ` Peter Hurley
2015-07-29 8:12 ` [RFC PATCH v2 2/3] genirq: Add a function to set irq affinity of candidate IRQs Taichi Kageyama
2015-07-29 8:13 ` [RFC PATCH v2 3/3] serial: 8250: Fix autoconfig_irq() to reduce the risk of failure Taichi Kageyama
2015-07-29 10:32 ` [RFC PATCH v2 0/3] genirq, serial: 8250: Workaround to avoid irq=0 for console Thomas Gleixner
2015-07-29 11:51 ` Peter Hurley
2015-07-29 11:53 ` Thomas Gleixner
2015-07-29 13:17 ` Peter Hurley
2015-07-29 13:35 ` Thomas Gleixner
2015-07-30 1:41 ` Taichi Kageyama
2015-07-30 10:12 ` Thomas Gleixner [this message]
2015-07-30 13:43 ` Peter Hurley
2015-07-30 22:12 ` Thomas Gleixner
2015-07-30 23:43 ` Peter Hurley
2015-07-31 7:02 ` Taichi Kageyama
2015-08-02 9:52 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1507301207070.3825@nanos \
--to=tglx@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=jiang.liu@linux.intel.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=peter@hurleysoftware.com \
--cc=peterz@infradead.org \
--cc=prarit@redhat.com \
--cc=t-kageyama@cp.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox