Re: [PATCH v3 10/16] HID: ft260: i2c: fix large write transaction failure

[sashiko-bot@kernel.org]

> Fixes a regression from commit 5afac727defa ("HID: ft260: missed NACK
> from busy device"), which waited for bus-idle after every HID write
> report except when the report flag was exactly FT260_FLAG_START.
> 
> Multi-report I2C writes keep the bus busy between chunks for atomicity.
> Treating those middle reports like a final STOP caused ft260_xfer_status()
> to spin on -EAGAIN after the second HID report and fail large writes.
> Write-then-read combined transfers still worked.
> 
> Pass the bus-busy check policy from the caller: ft260_i2c_write() and
> ft260_smbus_write() wait for idle only when the report they send carries
> STOP; intermediate chunks and the command phase of a combined transfer
> do not.
> 
> The SMBus side matters for register reads. The command phase is written
> [ ... ]
> Closes: https://github.com/MichaelZaidman/hid-ft260/issues/35
> Tested-by: Chris Keeser <chriskeeser@meta.com>
> Reported-by: Bruno Giacomazzi <brunoceg1@gmail.com>
> Closes: https://github.com/MichaelZaidman/hid-ft260/issues/42
> Signed-off-by: Michael Zaidman <michael.zaidman@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261114230800.1344401-1-michael.zaidman@gmail.com?part=10