Re: [PATCH v3 09/16] HID: ft260: group sysfs attrs per HID interface

[sashiko-bot@kernel.org]

> Split the single sysfs attribute group into per-interface groups based
> on chip mode (DCNF0/DCNF1):
> 
> - I2C-only (mode 1): I2C and GPIO attributes on the I2C HID interface
> - Dual mode (0/3): hid_over_i2c_en, i2c_reset and clock on the I2C
>   interface; GPIO and UART attrs on the UART interface
> - UART-only (mode 2): GPIO and UART attrs on the UART interface
> 
> i2c_enable is GPIO-related too: it switches GPIO0 and GPIO1 between I2C
> and GPIO, and its store updates gpio_en of its own interface. So it is
> on the interface with the gpiochip, the UART interface in modes 0 and 3.
> 
> i2c_reset is an I2C attribute, so it is only on the I2C interface and
> not in the UART group, which holds the GPIO and UART attributes.
> 
> Signed-off-by: Michael Zaidman <michael.zaidman@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261114230800.1344401-1-michael.zaidman@gmail.com?part=9