Re: [PATCH v3 03/16] HID: ft260: add GPIO support

[sashiko-bot@kernel.org]

> Add gpiochip support for the FT260 multifunctional pins, including
> GPIO2/GPIOA/GPIOG function selection via sysfs, and enable the
> available GPIOs according to the active UART mode.
> 
> This supersedes the earlier pre-UART GPIO series:
> https://lore.kernel.org/lkml/20230211115752.26276-2-michael.zaidman@gmail.com/
> 
> The change of the gpio_chip.set callback to return int, as the current
> gpiolib API requires, is based on a patch by Rio Liu <rio@r26.me>.
> 
> A pin set or direction change reads the FT260_GPIO report from the
> chip, changes the bits of that one pin and writes the report back. The
> other pins keep the state that the chip has, not a cached copy that
> can be zero. A change to output writes the direction and the value in
> the same report, and the error of a failed write goes back to gpiolib.
> [ ... ]
> The gpiochip is not devm: ft260_remove() frees dev before the devm
> actions run, so it removes the chip itself before it stops the HID
> device.
> 
> Signed-off-by: Michael Zaidman <michael.zaidman@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261114230800.1344401-1-michael.zaidman@gmail.com?part=3