Intel SGX development
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: linux-sgx@vger.kernel.org
Cc: luto@kernel.org, cedric.xing@intel.com,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Subject: [PATCH RFC] x86/sgx: Do not increase encl->refcount for VMAs
Date: Thu, 13 Jun 2019 19:30:07 +0300	[thread overview]
Message-ID: <20190613163008.4060-1-jarkko.sakkinen@linux.intel.com> (raw)

Since the device file stays open up until all VMAs have been closed
we do not need to increase encl->refcount for VMAs. sgx_open() will
increase it once and sgx_release() will decrease at a point where
the device file is not mapped. anymore.

Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
---
Based on the commentary from Andy and Cedric.
 arch/x86/kernel/cpu/sgx/driver/main.c | 2 --
 arch/x86/kernel/cpu/sgx/encl.c        | 3 ---
 2 files changed, 5 deletions(-)

diff --git a/arch/x86/kernel/cpu/sgx/driver/main.c b/arch/x86/kernel/cpu/sgx/driver/main.c
index 87735ce8b5ba..0c831ee5e2de 100644
--- a/arch/x86/kernel/cpu/sgx/driver/main.c
+++ b/arch/x86/kernel/cpu/sgx/driver/main.c
@@ -68,8 +68,6 @@ static int sgx_mmap(struct file *file, struct vm_area_struct *vma)
 	vma->vm_flags |= VM_PFNMAP | VM_DONTEXPAND | VM_DONTDUMP | VM_IO;
 	vma->vm_private_data = encl;
 
-	kref_get(&encl->refcount);
-
 	return 0;
 }
 
diff --git a/arch/x86/kernel/cpu/sgx/encl.c b/arch/x86/kernel/cpu/sgx/encl.c
index 6b190eccd02e..9566eb72d417 100644
--- a/arch/x86/kernel/cpu/sgx/encl.c
+++ b/arch/x86/kernel/cpu/sgx/encl.c
@@ -208,7 +208,6 @@ static void sgx_vma_open(struct vm_area_struct *vma)
 			goto error;
 	}
 
-	kref_get(&encl->refcount);
 	return;
 
 error:
@@ -230,8 +229,6 @@ static void sgx_vma_close(struct vm_area_struct *vma)
 		/* Release kref for the VMA. */
 		kref_put(&encl_mm->refcount, sgx_encl_mm_release);
 	}
-
-	kref_put(&encl->refcount, sgx_encl_release);
 }
 
 static unsigned int sgx_vma_fault(struct vm_fault *vmf)
-- 
2.20.1


             reply	other threads:[~2019-06-13 16:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-13 16:30 Jarkko Sakkinen [this message]
2019-06-13 16:30 ` [PATCH RFC] x86/sgx: Do not increase encl->refcount for VMAs Jarkko Sakkinen
2019-06-17 16:40 ` Jarkko Sakkinen
2019-06-17 16:52   ` Sean Christopherson
2019-06-19 12:46     ` Jarkko Sakkinen
2019-06-19 15:34       ` Sean Christopherson
2019-06-20 19:08         ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190613163008.4060-1-jarkko.sakkinen@linux.intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=cedric.xing@intel.com \
    --cc=linux-sgx@vger.kernel.org \
    --cc=luto@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox