Intel SGX development
 help / color / mirror / Atom feed
From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: linux-sgx@vger.kernel.org, luto@kernel.org, cedric.xing@intel.com
Subject: Re: [PATCH RFC] x86/sgx: Do not increase encl->refcount for VMAs
Date: Mon, 17 Jun 2019 09:52:25 -0700	[thread overview]
Message-ID: <20190617165224.GB25085@linux.intel.com> (raw)
In-Reply-To: <20190617164025.GA9762@linux.intel.com>

On Mon, Jun 17, 2019 at 07:40:25PM +0300, Jarkko Sakkinen wrote:
> On Thu, Jun 13, 2019 at 07:30:07PM +0300, Jarkko Sakkinen wrote:
> > Since the device file stays open up until all VMAs have been closed
> > we do not need to increase encl->refcount for VMAs. sgx_open() will
> > increase it once and sgx_release() will decrease at a point where
> > the device file is not mapped. anymore.
> > 
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> 
> Cool if I merge this one?

LGTM

  reply	other threads:[~2019-06-17 16:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-13 16:30 [PATCH RFC] x86/sgx: Do not increase encl->refcount for VMAs Jarkko Sakkinen
2019-06-13 16:30 ` Jarkko Sakkinen
2019-06-17 16:40 ` Jarkko Sakkinen
2019-06-17 16:52   ` Sean Christopherson [this message]
2019-06-19 12:46     ` Jarkko Sakkinen
2019-06-19 15:34       ` Sean Christopherson
2019-06-20 19:08         ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190617165224.GB25085@linux.intel.com \
    --to=sean.j.christopherson@intel.com \
    --cc=cedric.xing@intel.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=linux-sgx@vger.kernel.org \
    --cc=luto@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox