From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: linux-sgx@vger.kernel.org, luto@kernel.org, cedric.xing@intel.com
Subject: Re: [PATCH RFC] x86/sgx: Do not increase encl->refcount for VMAs
Date: Wed, 19 Jun 2019 08:34:19 -0700 [thread overview]
Message-ID: <20190619153419.GE1203@linux.intel.com> (raw)
In-Reply-To: <4a6512f4dff6036c4f66c1f27ce820308d5839ef.camel@linux.intel.com>
On Wed, Jun 19, 2019 at 03:46:38PM +0300, Jarkko Sakkinen wrote:
> On Mon, 2019-06-17 at 09:52 -0700, Sean Christopherson wrote:
> > On Mon, Jun 17, 2019 at 07:40:25PM +0300, Jarkko Sakkinen wrote:
> > > On Thu, Jun 13, 2019 at 07:30:07PM +0300, Jarkko Sakkinen wrote:
> > > > Since the device file stays open up until all VMAs have been closed
> > > > we do not need to increase encl->refcount for VMAs. sgx_open() will
> > > > increase it once and sgx_release() will decrease at a point where
> > > > the device file is not mapped. anymore.
> > > >
> > > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > >
> > > Cool if I merge this one?
> >
> > LGTM
>
> Awesome, merged.
>
> Sent another similar change just now for the page adder. Can you
> check that so I can merge.
>
> I have a change in progress that will make the reclaimer also the
> reaper and remove the need for the refcount altogether. Try to
> get it possibly tonight out (i.e. daytime for you).
I'm about to disappear on vacation for two weeks, can you post whatever
you have, even if it's half baked?
I have a working patch to use mmu_notifier.release() instead of per-vma
refcounting, I'll post an RFC today. It'd be nice to have both approaches
posted so that folks can weigh in on the options for dropping .vm_close().
next prev parent reply other threads:[~2019-06-19 15:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 16:30 [PATCH RFC] x86/sgx: Do not increase encl->refcount for VMAs Jarkko Sakkinen
2019-06-13 16:30 ` Jarkko Sakkinen
2019-06-17 16:40 ` Jarkko Sakkinen
2019-06-17 16:52 ` Sean Christopherson
2019-06-19 12:46 ` Jarkko Sakkinen
2019-06-19 15:34 ` Sean Christopherson [this message]
2019-06-20 19:08 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190619153419.GE1203@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=cedric.xing@intel.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-sgx@vger.kernel.org \
--cc=luto@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox