* Re: [PATCH] ARM: shmobile: ape6evm: Fix LAN9220 VDDVARIO voltage
2014-12-16 23:17 [PATCH] ARM: shmobile: ape6evm: Fix LAN9220 VDDVARIO voltage Laurent Pinchart
@ 2014-12-17 0:26 ` Simon Horman
2014-12-17 0:30 ` Laurent Pinchart
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2014-12-17 0:26 UTC (permalink / raw)
To: linux-sh
On Wed, Dec 17, 2014 at 01:17:25AM +0200, Laurent Pinchart wrote:
> The LAN9220 VDDVARIO supply is powered by a 1.8V source, not 3.3V. Fix
> it in the device tree.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> arch/arm/boot/dts/r8a73a4-ape6evm.dts | 14 +++++++++++---
> 1 file changed, 11 insertions(+), 3 deletions(-)
>
> This patch is based on top of Ulrich's "[PATCH v2 0/7] ARM: shmobile: ape6evm:
> multiplatform support" series, but it could easily be rebased to apply without
> that dependency.
My preference is to take this fix before Ulrich's series.
But I am happy to negotiate if others have a different preference.
>
> diff --git a/arch/arm/boot/dts/r8a73a4-ape6evm.dts b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> index 6b7bc1fb842e..0d50bef01234 100644
> --- a/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> +++ b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> @@ -55,8 +55,16 @@
> enable-active-high;
> };
>
> - /* Common 3.3V rail, used by several devices on APE6EVM */
> - ape6evm_fixed_3v3: regulator@2 {
> + /* Common 1.8V and 3.3V rails, used by several devices on APE6EVM */
> + ape6evm_fixed_1v8: regulator@2 {
> + compatible = "regulator-fixed";
> + regulator-name = "1V8";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + };
> +
> + ape6evm_fixed_3v3: regulator@3 {
> compatible = "regulator-fixed";
> regulator-name = "3V3";
> regulator-min-microvolt = <3300000>;
> @@ -80,7 +88,7 @@
> smsc,irq-active-high;
> smsc,irq-push-pull;
> vdd33a-supply = <&ape6evm_fixed_3v3>;
> - vddvario-supply = <&ape6evm_fixed_3v3>;
> + vddvario-supply = <&ape6evm_fixed_1v8>;
> };
> };
>
> --
> Regards,
>
> Laurent Pinchart
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: shmobile: ape6evm: Fix LAN9220 VDDVARIO voltage
2014-12-16 23:17 [PATCH] ARM: shmobile: ape6evm: Fix LAN9220 VDDVARIO voltage Laurent Pinchart
2014-12-17 0:26 ` Simon Horman
@ 2014-12-17 0:30 ` Laurent Pinchart
2014-12-18 0:43 ` Simon Horman
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2014-12-17 0:30 UTC (permalink / raw)
To: linux-sh
Hi Simon,
On Wednesday 17 December 2014 09:26:55 Simon Horman wrote:
> On Wed, Dec 17, 2014 at 01:17:25AM +0200, Laurent Pinchart wrote:
> > The LAN9220 VDDVARIO supply is powered by a 1.8V source, not 3.3V. Fix
> > it in the device tree.
> >
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> >
> > arch/arm/boot/dts/r8a73a4-ape6evm.dts | 14 +++++++++++---
> > 1 file changed, 11 insertions(+), 3 deletions(-)
> >
> > This patch is based on top of Ulrich's "[PATCH v2 0/7] ARM: shmobile:
> > ape6evm: multiplatform support" series, but it could easily be rebased to
> > apply without that dependency.
>
> My preference is to take this fix before Ulrich's series.
> But I am happy to negotiate if others have a different preference.
Just for the record I have no preference given that this fix doesn't have any
influence on the system.
> > diff --git a/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> > b/arch/arm/boot/dts/r8a73a4-ape6evm.dts index 6b7bc1fb842e..0d50bef01234
> > 100644
> > --- a/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> > +++ b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> > @@ -55,8 +55,16 @@
> > enable-active-high;
> > };
> >
> > - /* Common 3.3V rail, used by several devices on APE6EVM */
> > - ape6evm_fixed_3v3: regulator@2 {
> > + /* Common 1.8V and 3.3V rails, used by several devices on APE6EVM */
> > + ape6evm_fixed_1v8: regulator@2 {
> > + compatible = "regulator-fixed";
> > + regulator-name = "1V8";
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > + regulator-always-on;
> > + };
> > +
> > + ape6evm_fixed_3v3: regulator@3 {
> > compatible = "regulator-fixed";
> > regulator-name = "3V3";
> > regulator-min-microvolt = <3300000>;
> > @@ -80,7 +88,7 @@
> > smsc,irq-active-high;
> > smsc,irq-push-pull;
> > vdd33a-supply = <&ape6evm_fixed_3v3>;
> > - vddvario-supply = <&ape6evm_fixed_3v3>;
> > + vddvario-supply = <&ape6evm_fixed_1v8>;
> > };
> > };
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: shmobile: ape6evm: Fix LAN9220 VDDVARIO voltage
2014-12-16 23:17 [PATCH] ARM: shmobile: ape6evm: Fix LAN9220 VDDVARIO voltage Laurent Pinchart
2014-12-17 0:26 ` Simon Horman
2014-12-17 0:30 ` Laurent Pinchart
@ 2014-12-18 0:43 ` Simon Horman
2014-12-18 2:30 ` Laurent Pinchart
2014-12-19 0:11 ` Simon Horman
4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2014-12-18 0:43 UTC (permalink / raw)
To: linux-sh
On Wed, Dec 17, 2014 at 02:30:08AM +0200, Laurent Pinchart wrote:
> Hi Simon,
>
> On Wednesday 17 December 2014 09:26:55 Simon Horman wrote:
> > On Wed, Dec 17, 2014 at 01:17:25AM +0200, Laurent Pinchart wrote:
> > > The LAN9220 VDDVARIO supply is powered by a 1.8V source, not 3.3V. Fix
> > > it in the device tree.
> > >
> > > Signed-off-by: Laurent Pinchart
> > > <laurent.pinchart+renesas@ideasonboard.com>
> > > ---
> > >
> > > arch/arm/boot/dts/r8a73a4-ape6evm.dts | 14 +++++++++++---
> > > 1 file changed, 11 insertions(+), 3 deletions(-)
> > >
> > > This patch is based on top of Ulrich's "[PATCH v2 0/7] ARM: shmobile:
> > > ape6evm: multiplatform support" series, but it could easily be rebased to
> > > apply without that dependency.
> >
> > My preference is to take this fix before Ulrich's series.
> > But I am happy to negotiate if others have a different preference.
>
> Just for the record I have no preference given that this fix doesn't have any
> influence on the system.
Thanks, in that case I don't feel strongly about it either.
But lets try not to let it slip through the cracks.
> > > diff --git a/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> > > b/arch/arm/boot/dts/r8a73a4-ape6evm.dts index 6b7bc1fb842e..0d50bef01234
> > > 100644
> > > --- a/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> > > +++ b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> > > @@ -55,8 +55,16 @@
> > > enable-active-high;
> > > };
> > >
> > > - /* Common 3.3V rail, used by several devices on APE6EVM */
> > > - ape6evm_fixed_3v3: regulator@2 {
> > > + /* Common 1.8V and 3.3V rails, used by several devices on APE6EVM */
> > > + ape6evm_fixed_1v8: regulator@2 {
> > > + compatible = "regulator-fixed";
> > > + regulator-name = "1V8";
> > > + regulator-min-microvolt = <1800000>;
> > > + regulator-max-microvolt = <1800000>;
> > > + regulator-always-on;
> > > + };
> > > +
> > > + ape6evm_fixed_3v3: regulator@3 {
> > > compatible = "regulator-fixed";
> > > regulator-name = "3V3";
> > > regulator-min-microvolt = <3300000>;
> > > @@ -80,7 +88,7 @@
> > > smsc,irq-active-high;
> > > smsc,irq-push-pull;
> > > vdd33a-supply = <&ape6evm_fixed_3v3>;
> > > - vddvario-supply = <&ape6evm_fixed_3v3>;
> > > + vddvario-supply = <&ape6evm_fixed_1v8>;
> > > };
> > > };
>
> --
> Regards,
>
> Laurent Pinchart
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: shmobile: ape6evm: Fix LAN9220 VDDVARIO voltage
2014-12-16 23:17 [PATCH] ARM: shmobile: ape6evm: Fix LAN9220 VDDVARIO voltage Laurent Pinchart
` (2 preceding siblings ...)
2014-12-18 0:43 ` Simon Horman
@ 2014-12-18 2:30 ` Laurent Pinchart
2014-12-19 0:11 ` Simon Horman
4 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2014-12-18 2:30 UTC (permalink / raw)
To: linux-sh
Hi Simon,
On Thursday 18 December 2014 09:43:56 Simon Horman wrote:
> On Wed, Dec 17, 2014 at 02:30:08AM +0200, Laurent Pinchart wrote:
> > On Wednesday 17 December 2014 09:26:55 Simon Horman wrote:
> > > On Wed, Dec 17, 2014 at 01:17:25AM +0200, Laurent Pinchart wrote:
> > > > The LAN9220 VDDVARIO supply is powered by a 1.8V source, not 3.3V. Fix
> > > > it in the device tree.
> > > >
> > > > Signed-off-by: Laurent Pinchart
> > > > <laurent.pinchart+renesas@ideasonboard.com>
> > > > ---
> > > >
> > > > arch/arm/boot/dts/r8a73a4-ape6evm.dts | 14 +++++++++++---
> > > > 1 file changed, 11 insertions(+), 3 deletions(-)
> > > >
> > > > This patch is based on top of Ulrich's "[PATCH v2 0/7] ARM: shmobile:
> > > > ape6evm: multiplatform support" series, but it could easily be rebased
> > > > to apply without that dependency.
> > >
> > > My preference is to take this fix before Ulrich's series.
> > > But I am happy to negotiate if others have a different preference.
> >
> > Just for the record I have no preference given that this fix doesn't have
> > any influence on the system.
>
> Thanks, in that case I don't feel strongly about it either.
> But lets try not to let it slip through the cracks.
Given that you've just merged the dependencies I think you can merge this
patch :-)
> > > > diff --git a/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> > > > b/arch/arm/boot/dts/r8a73a4-ape6evm.dts index
> > > > 6b7bc1fb842e..0d50bef01234
> > > > 100644
> > > > --- a/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> > > > +++ b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> > > > @@ -55,8 +55,16 @@
> > > >
> > > > enable-active-high;
> > > >
> > > > };
> > > >
> > > > - /* Common 3.3V rail, used by several devices on APE6EVM */
> > > > - ape6evm_fixed_3v3: regulator@2 {
> > > > + /* Common 1.8V and 3.3V rails, used by several devices on APE6EVM */
> > > > + ape6evm_fixed_1v8: regulator@2 {
> > > > + compatible = "regulator-fixed";
> > > > + regulator-name = "1V8";
> > > > + regulator-min-microvolt = <1800000>;
> > > > + regulator-max-microvolt = <1800000>;
> > > > + regulator-always-on;
> > > > + };
> > > > +
> > > > + ape6evm_fixed_3v3: regulator@3 {
> > > >
> > > > compatible = "regulator-fixed";
> > > > regulator-name = "3V3";
> > > > regulator-min-microvolt = <3300000>;
> > > >
> > > > @@ -80,7 +88,7 @@
> > > >
> > > > smsc,irq-active-high;
> > > > smsc,irq-push-pull;
> > > > vdd33a-supply = <&ape6evm_fixed_3v3>;
> > > >
> > > > - vddvario-supply = <&ape6evm_fixed_3v3>;
> > > > + vddvario-supply = <&ape6evm_fixed_1v8>;
> > > >
> > > > };
> > > >
> > > > };
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: shmobile: ape6evm: Fix LAN9220 VDDVARIO voltage
2014-12-16 23:17 [PATCH] ARM: shmobile: ape6evm: Fix LAN9220 VDDVARIO voltage Laurent Pinchart
` (3 preceding siblings ...)
2014-12-18 2:30 ` Laurent Pinchart
@ 2014-12-19 0:11 ` Simon Horman
4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2014-12-19 0:11 UTC (permalink / raw)
To: linux-sh
On Thu, Dec 18, 2014 at 04:30:12AM +0200, Laurent Pinchart wrote:
> Hi Simon,
>
> On Thursday 18 December 2014 09:43:56 Simon Horman wrote:
> > On Wed, Dec 17, 2014 at 02:30:08AM +0200, Laurent Pinchart wrote:
> > > On Wednesday 17 December 2014 09:26:55 Simon Horman wrote:
> > > > On Wed, Dec 17, 2014 at 01:17:25AM +0200, Laurent Pinchart wrote:
> > > > > The LAN9220 VDDVARIO supply is powered by a 1.8V source, not 3.3V. Fix
> > > > > it in the device tree.
> > > > >
> > > > > Signed-off-by: Laurent Pinchart
> > > > > <laurent.pinchart+renesas@ideasonboard.com>
> > > > > ---
> > > > >
> > > > > arch/arm/boot/dts/r8a73a4-ape6evm.dts | 14 +++++++++++---
> > > > > 1 file changed, 11 insertions(+), 3 deletions(-)
> > > > >
> > > > > This patch is based on top of Ulrich's "[PATCH v2 0/7] ARM: shmobile:
> > > > > ape6evm: multiplatform support" series, but it could easily be rebased
> > > > > to apply without that dependency.
> > > >
> > > > My preference is to take this fix before Ulrich's series.
> > > > But I am happy to negotiate if others have a different preference.
> > >
> > > Just for the record I have no preference given that this fix doesn't have
> > > any influence on the system.
> >
> > Thanks, in that case I don't feel strongly about it either.
> > But lets try not to let it slip through the cracks.
>
> Given that you've just merged the dependencies I think you can merge this
> patch :-)
Indeed, done :)
^ permalink raw reply [flat|nested] 6+ messages in thread