From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: linux-sh@vger.kernel.org
Subject: Re: [BUG] on sh7372 (mackerel) with today's Linus' (github) master
Date: Mon, 26 Sep 2011 08:39:24 +0000 [thread overview]
Message-ID: <20110926083924.GD22455@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.1109231012490.25166@axis700.grange>
On Sat, Sep 24, 2011 at 03:07:07PM +0200, Rafael J. Wysocki wrote:
> On Saturday, September 24, 2011, Russell King - ARM Linux wrote:
> > On Sat, Sep 24, 2011 at 12:58:37AM +0200, Rafael J. Wysocki wrote:
> > > Well, since nobody seems to execute anything that may sleep under
> > > clocks_mutex, perhaps we can do something like this:
> >
> > No - a spinlock prevents preemption, a mutex does not.
> >
> > It's runtime PM which is doing stuff wrong here. You're not supposed to
> > give up the clk struct with it enabled.
>
> OK, so below is a fix confined to clock_ops.c.
Looks fine from a read-through the patch, thanks.
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
next prev parent reply other threads:[~2011-09-26 8:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 8:17 [BUG] on sh7372 (mackerel) with today's Linus' (github) master Guennadi Liakhovetski
2011-09-23 22:21 ` Rafael J. Wysocki
2011-09-23 22:58 ` Rafael J. Wysocki
2011-09-24 8:09 ` Russell King - ARM Linux
2011-09-24 13:07 ` Rafael J. Wysocki
2011-09-26 8:39 ` Russell King - ARM Linux [this message]
2011-09-26 17:25 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110926083924.GD22455@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox