* [PATCH v5 0/5] arm64: dts: r8a7795: enable EthernetAVB on Salvator-X
@ 2015-10-15 6:48 Simon Horman
2015-10-15 6:48 ` [PATCH v5 1/5] arm64: dts: r8a7795: add clock for EthernetAVB Simon Horman
` (6 more replies)
0 siblings, 7 replies; 11+ messages in thread
From: Simon Horman @ 2015-10-15 6:48 UTC (permalink / raw)
To: linux-arm-kernel
This patchset enables the EthernetAVB on the Salvator-X board.
With it and its dependencies in place I have have successfully
booted to an nfsroot user-space (arm64 Debian Jessie).
In order to achieve that I used the following command line set from u-boot.
As per "[PATCH v11 0/8] arm64: renesas: Add Renesas R8A7795 SoC support":
This series has undergone a number of rounds of development and
review on the linux-sh mailing list. This is the first posting to a
wider audience from which we are now seeking review.
It is anticipated that the CPG bindings used this patchset will be
changed before they hit mainline and thus this patchset will need
to be updated accordingly. Reviewers are advised to skip over that
portion of this patchset unless they have a particular interest in
that discussion.
root=/dev/nfs ip=dhcp nfsroot\x10.3.3.135:/srv/nfs/salvator-x-arm64
Changes:
* See changelog of individual patches
* Only change since v4 is rebase
Base:
This is based on:
* "[PATCH v11 0/8] arm64: renesas: Add Renesas R8A7795 SoC support"
- topic/arm64-rcar-gen3-v11 branch of my renesas tree
Runtime Dependencies:
* The base (above)
* "[PATCH/RFC v3 net-next 0/4] ravb: Add support for r8a7795 SoC"
and its dependencies
- David Miller's net-next tree
* v4.3-rc2 for "[PATCH] gpio: rcar: GPIO_RCAR doesn't relate to ARM"
- Included in net-next
* "[PATCH 0/3] Basic GPIO support for r8a7795"
- topic/r8a7795-gpio-v1.rebase3 branch of my renesas tree
* "[PATCH/RFC v2] sh-pfc: r8a7795: add EtherAVB support"
and its dependencies
- me/r8a7795-ravb-pfc-v2 branch of my renesas tree
* "[PATCH v8 00/05] Renesas R-Car Gen3 CPG support V8"
- topic/gen3-cpg-v8+fix branch of Geert Uytterhoeven's renesas-drivers tree
Availability:
To aid review of this and other EtherAVB patches the following branches are
available in my renesas tree on kernel.org.
* me/r8a7795-ravb-pfc-v2: PFC update for EthernetAVB on r8a7795
* me/r8a7795-ravb-integration-v5: this patchset
* me/r8a7795-ravb-driver-and-integration-v5.runtime:
the above three branches with their runtime dependencies
Kazuya Mizuguchi (3):
arm64: dts: r8a7795: add clock for EthernetAVB
arm64: dts: r8a7795: add EthernetAVB device node
arm64: dts: r8a7795: enable EthernetAVB on Salvator-X
Simon Horman (2):
arm64: dts: r8a7795: enable nfs root on Salvator-X board
arm64: defconfig: enable EthernetAVB
arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 33 ++++++++++++-
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 54 ++++++++++++++++++++++
arch/arm64/configs/defconfig | 2 +
include/dt-bindings/clock/r8a7795-clock.h | 1 +
4 files changed, 89 insertions(+), 1 deletion(-)
--
2.1.4
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v5 1/5] arm64: dts: r8a7795: add clock for EthernetAVB
2015-10-15 6:48 [PATCH v5 0/5] arm64: dts: r8a7795: enable EthernetAVB on Salvator-X Simon Horman
@ 2015-10-15 6:48 ` Simon Horman
2015-10-15 6:48 ` [PATCH v5 2/5] arm64: dts: r8a7795: add EthernetAVB device node Simon Horman
` (5 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Simon Horman @ 2015-10-15 6:48 UTC (permalink / raw)
To: linux-arm-kernel
From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
These clocks will be used by EthernetAVB
Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
[horms: use s3d2_clk; other minor updates]
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v0 [Kazuya Mizuguchi]
v1 [Simon Horman]
* updated p_clk to s3d4_clk
* moved to clock node
* updated patch subject
* use R8A7795 as prefix for clock defines
v2 [Simon Horman]
* As suggested by Geert Uytterhoeven
- Use s3d2_clk use it instead: it is now already present in the base
of this series
- Use R8A7795_CLK_ETHERAVB instead of R8A7795_CLK_AVB
* As suggested by Kuninori Morimoto and Sergei Shtylyov
- Use "clock-indices" instead of "renesas,clock-indices"
v3 [Simon Horman]
* As suggested by Geert Uytterhoeven
- Name clock "etheravb"
* Add Ack
v4, v5
* No change
TODO:
* Drop clock-output-names from mstp8_clks ?
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 12 ++++++++++++
include/dt-bindings/clock/r8a7795-clock.h | 1 +
2 files changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index e2cc40fa5aa3..6efa49f97e07 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -289,6 +289,17 @@
"scif2";
#reset-cells = <1>;
};
+
+ mstp8_clks: mstp8_clks@e6150990 {
+ compatible = "renesas,r8a7795-mstp-clocks",
+ "renesas,cpg-mstp-clocks";
+ reg = <0 0xe6150990 0 4>, <0 0xe61509a0 0 4>;
+ clocks = <&s3d2_clk>;
+ #clock-cells = <1>;
+ clock-indices = <R8A7795_CLK_ETHERAVB>;
+ clock-output-names = "etheravb";
+ };
+
};
};
@@ -381,4 +392,5 @@
status = "disabled";
};
};
+
};
diff --git a/include/dt-bindings/clock/r8a7795-clock.h b/include/dt-bindings/clock/r8a7795-clock.h
index 51048d79f80d..be8d8192720e 100644
--- a/include/dt-bindings/clock/r8a7795-clock.h
+++ b/include/dt-bindings/clock/r8a7795-clock.h
@@ -36,6 +36,7 @@
/* MSTP7 */
/* MSTP8 */
+#define R8A7795_CLK_ETHERAVB 12
/* MSTP9 */
--
2.1.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v5 2/5] arm64: dts: r8a7795: add EthernetAVB device node
2015-10-15 6:48 [PATCH v5 0/5] arm64: dts: r8a7795: enable EthernetAVB on Salvator-X Simon Horman
2015-10-15 6:48 ` [PATCH v5 1/5] arm64: dts: r8a7795: add clock for EthernetAVB Simon Horman
@ 2015-10-15 6:48 ` Simon Horman
2015-10-29 8:42 ` Magnus Damm
2015-10-15 6:48 ` [PATCH v5 3/5] arm64: dts: r8a7795: enable EthernetAVB on Salvator-X Simon Horman
` (4 subsequent siblings)
6 siblings, 1 reply; 11+ messages in thread
From: Simon Horman @ 2015-10-15 6:48 UTC (permalink / raw)
To: linux-arm-kernel
From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
[horms: minor updates]
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v0 [Kazuya Mizuguchi]
v1 [Simon Horman]
* moved to soc node
* updated patch subject
v2 [Simon Horman]
* Specify all interrupts
* Use named interrupts
* Rebase
* Remove spurious whitespace change introduce in v1
v3 [Simon Horman]
* As suggested by Geert Uytterhoeven
- Add power-domains property
* Added Ack
v4, v5
* No change
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 42 ++++++++++++++++++++++++++++++++
1 file changed, 42 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index 6efa49f97e07..63bc74e89fa4 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -312,6 +312,48 @@
/* Empty node for now */
};
+ avb: ethernet@e6800000 {
+ compatible = "renesas,etheravb-r8a7795";
+ reg = <0 0xe6800000 0 0x800>, <0 0xe6a00000 0 0x10000>;
+ interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "ch0", "ch1", "ch2", "ch3",
+ "ch4", "ch5", "ch6", "ch7",
+ "ch8", "ch9", "ch10", "ch11",
+ "ch12", "ch13", "ch14", "ch15",
+ "ch16", "ch17", "ch18", "ch19",
+ "ch20", "ch21", "ch22", "ch23",
+ "ch24";
+ clocks = <&mstp8_clks R8A7795_CLK_ETHERAVB>;
+ power-domains = <&cpg_clocks>;
+ phy-mode = "rgmii-id";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+
dmac1: dma-controller@e7300000 {
/* Empty node for now */
};
--
2.1.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v5 3/5] arm64: dts: r8a7795: enable EthernetAVB on Salvator-X
2015-10-15 6:48 [PATCH v5 0/5] arm64: dts: r8a7795: enable EthernetAVB on Salvator-X Simon Horman
2015-10-15 6:48 ` [PATCH v5 1/5] arm64: dts: r8a7795: add clock for EthernetAVB Simon Horman
2015-10-15 6:48 ` [PATCH v5 2/5] arm64: dts: r8a7795: add EthernetAVB device node Simon Horman
@ 2015-10-15 6:48 ` Simon Horman
2015-10-15 6:48 ` [PATCH v5 4/5] arm64: dts: r8a7795: enable nfs root on Salvator-X board Simon Horman
` (3 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Simon Horman @ 2015-10-15 6:48 UTC (permalink / raw)
To: linux-arm-kernel
From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
[horms: minor updates]
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
v0 [Kazuya Mizuguchi]
v1 [Simon Horman]
* updated filename to salvator-x
* updated patch subject
v2 [Simon Horman]
* Removed spurious update to r8a7795.dtsi introduced in v1
* Removed unused renesas,phy property
v3 [Simon Horman]
* No change but provided PFC driver update in separate patch(set)
v4 [Simon Horman]
* As suggested by Sergei Shtylyov
- Removed unused phy-reset-gpio property
v5
* No change
---
arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 31 ++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
index f522fda7843a..4fb120d8e7e8 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
@@ -45,6 +45,11 @@
renesas,groups = "scif2_data_a";
renesas,function = "scif2";
};
+
+ avb_pins: avb {
+ renesas,groups = "avb_mdc";
+ renesas,function = "avb";
+ };
};
&scif1 {
@@ -60,3 +65,29 @@
status = "okay";
};
+
+&avb {
+ pinctrl-0 = <&avb_pins>;
+ pinctrl-names = "default";
+ renesas,no-ether-link;
+ phy-handle = <&phy0>;
+ status = "okay";
+
+ phy0: ethernet-phy@0 {
+ rxc-skew-ps = <900>;
+ rxdv-skew-ps = <0>;
+ rxd0-skew-ps = <0>;
+ rxd1-skew-ps = <0>;
+ rxd2-skew-ps = <0>;
+ rxd3-skew-ps = <0>;
+ txc-skew-ps = <900>;
+ txen-skew-ps = <0>;
+ txd0-skew-ps = <0>;
+ txd1-skew-ps = <0>;
+ txd2-skew-ps = <0>;
+ txd3-skew-ps = <0>;
+ reg = <0>;
+ interrupt-parent = <&gpio2>;
+ interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
+ };
+};
--
2.1.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v5 4/5] arm64: dts: r8a7795: enable nfs root on Salvator-X board
2015-10-15 6:48 [PATCH v5 0/5] arm64: dts: r8a7795: enable EthernetAVB on Salvator-X Simon Horman
` (2 preceding siblings ...)
2015-10-15 6:48 ` [PATCH v5 3/5] arm64: dts: r8a7795: enable EthernetAVB on Salvator-X Simon Horman
@ 2015-10-15 6:48 ` Simon Horman
2015-10-15 6:48 ` [PATCH v5 5/5] arm64: defconfig: enable EthernetAVB Simon Horman
` (2 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Simon Horman @ 2015-10-15 6:48 UTC (permalink / raw)
To: linux-arm-kernel
As has been the practice for boards for 32bit ARM Renesas SoCs
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
--
v2
* No change
v3
* Added Ack
v4, v5
* No change
---
arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
index 4fb120d8e7e8..d1c2fea8bebc 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
@@ -21,7 +21,7 @@
};
chosen {
- bootargs = "ignore_loglevel";
+ bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp";
stdout-path = &scif2;
};
--
2.1.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v5 5/5] arm64: defconfig: enable EthernetAVB
2015-10-15 6:48 [PATCH v5 0/5] arm64: dts: r8a7795: enable EthernetAVB on Salvator-X Simon Horman
` (3 preceding siblings ...)
2015-10-15 6:48 ` [PATCH v5 4/5] arm64: dts: r8a7795: enable nfs root on Salvator-X board Simon Horman
@ 2015-10-15 6:48 ` Simon Horman
2015-10-27 10:41 ` [PATCH v5 0/5] arm64: dts: r8a7795: enable EthernetAVB on Salvator-X Geert Uytterhoeven
2015-11-20 1:22 ` Simon Horman
6 siblings, 0 replies; 11+ messages in thread
From: Simon Horman @ 2015-10-15 6:48 UTC (permalink / raw)
To: linux-arm-kernel
This is present on the Renesas r8a7795 SoC and may be
used by the Salvator-X board.
Also enable MICREL_PHY which is used on the Salvator-X board.
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2
* Enable MICREL_PHY
v3
* Added Ack
v4, v5
* No change
---
arch/arm64/configs/defconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index dccc685b58ae..79a09de4f52f 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -97,8 +97,10 @@ CONFIG_TUN=y
CONFIG_VIRTIO_NET=y
CONFIG_NET_XGENE=y
CONFIG_SKY2=y
+CONFIG_RAVB=y
CONFIG_SMC91X=y
CONFIG_SMSC911X=y
+CONFIG_MICREL_PHY=y
# CONFIG_WLAN is not set
CONFIG_INPUT_EVDEV=y
CONFIG_KEYBOARD_GPIO=y
--
2.1.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v5 0/5] arm64: dts: r8a7795: enable EthernetAVB on Salvator-X
2015-10-15 6:48 [PATCH v5 0/5] arm64: dts: r8a7795: enable EthernetAVB on Salvator-X Simon Horman
` (4 preceding siblings ...)
2015-10-15 6:48 ` [PATCH v5 5/5] arm64: defconfig: enable EthernetAVB Simon Horman
@ 2015-10-27 10:41 ` Geert Uytterhoeven
2015-11-20 1:22 ` Simon Horman
6 siblings, 0 replies; 11+ messages in thread
From: Geert Uytterhoeven @ 2015-10-27 10:41 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 15, 2015 at 8:48 AM, Simon Horman
<horms+renesas@verge.net.au> wrote:
> This patchset enables the EthernetAVB on the Salvator-X board.
> With it and its dependencies in place I have have successfully
> booted to an nfsroot user-space (arm64 Debian Jessie).
>
> In order to achieve that I used the following command line set from u-boot.
> root=/dev/nfs ip=dhcp nfsroot\x10.3.3.135:/srv/nfs/salvator-x-arm64
For people who want to try this: you probably want to add a line specifying
the MAC address
local-mac-address = [ XX XX XX XX XX XX ];
to the avb node in arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v5 2/5] arm64: dts: r8a7795: add EthernetAVB device node
2015-10-15 6:48 ` [PATCH v5 2/5] arm64: dts: r8a7795: add EthernetAVB device node Simon Horman
@ 2015-10-29 8:42 ` Magnus Damm
2015-10-30 7:17 ` Simon Horman
0 siblings, 1 reply; 11+ messages in thread
From: Magnus Damm @ 2015-10-29 8:42 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 15, 2015 at 3:48 PM, Simon Horman
<horms+renesas@verge.net.au> wrote:
> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>
> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> [horms: minor updates]
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> ---
> v0 [Kazuya Mizuguchi]
>
> v1 [Simon Horman]
> * moved to soc node
> * updated patch subject
>
> v2 [Simon Horman]
> * Specify all interrupts
> * Use named interrupts
> * Rebase
> * Remove spurious whitespace change introduce in v1
>
> v3 [Simon Horman]
> * As suggested by Geert Uytterhoeven
> - Add power-domains property
> * Added Ack
>
> v4, v5
> * No change
> ---
> arch/arm64/boot/dts/renesas/r8a7795.dtsi | 42 ++++++++++++++++++++++++++++++++
> 1 file changed, 42 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> index 6efa49f97e07..63bc74e89fa4 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> @@ -312,6 +312,48 @@
> /* Empty node for now */
> };
>
> + avb: ethernet@e6800000 {
> + compatible = "renesas,etheravb-r8a7795";
> + reg = <0 0xe6800000 0 0x800>, <0 0xe6a00000 0 0x10000>;
> + interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "ch0", "ch1", "ch2", "ch3",
> + "ch4", "ch5", "ch6", "ch7",
> + "ch8", "ch9", "ch10", "ch11",
> + "ch12", "ch13", "ch14", "ch15",
> + "ch16", "ch17", "ch18", "ch19",
> + "ch20", "ch21", "ch22", "ch23",
> + "ch24";
> + clocks = <&mstp8_clks R8A7795_CLK_ETHERAVB>;
> + power-domains = <&cpg_clocks>;
> + phy-mode = "rgmii-id";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> +
> dmac1: dma-controller@e7300000 {
> /* Empty node for now */
> };
> --
> 2.1.4
>
Hi Simon,
Thanks for your efforts with the ethernet controller. In general all
seems good to me, but this I came across the contents of this patch
when I was browsing the SoC DTSI file. What is the reason to put this
node in between dmac0 and dmac1? I don't know where is the best
location, but it would be good to keep the dmac nodes together I
think.
Cheers,
/ magnus
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v5 2/5] arm64: dts: r8a7795: add EthernetAVB device node
2015-10-29 8:42 ` Magnus Damm
@ 2015-10-30 7:17 ` Simon Horman
2015-10-30 7:25 ` Simon Horman
0 siblings, 1 reply; 11+ messages in thread
From: Simon Horman @ 2015-10-30 7:17 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 29, 2015 at 05:42:43PM +0900, Magnus Damm wrote:
> On Thu, Oct 15, 2015 at 3:48 PM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> >
> > Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> > [horms: minor updates]
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
[snip]
> Hi Simon,
>
> Thanks for your efforts with the ethernet controller. In general all
> seems good to me, but this I came across the contents of this patch
> when I was browsing the SoC DTSI file. What is the reason to put this
> node in between dmac0 and dmac1? I don't know where is the best
> location, but it would be good to keep the dmac nodes together I
> think.
I think its just an artifact of the way the patch has been updated.
I'll see about cleaning it up.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v5 2/5] arm64: dts: r8a7795: add EthernetAVB device node
2015-10-30 7:17 ` Simon Horman
@ 2015-10-30 7:25 ` Simon Horman
0 siblings, 0 replies; 11+ messages in thread
From: Simon Horman @ 2015-10-30 7:25 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Oct 30, 2015 at 04:17:46PM +0900, Simon Horman wrote:
> On Thu, Oct 29, 2015 at 05:42:43PM +0900, Magnus Damm wrote:
> > On Thu, Oct 15, 2015 at 3:48 PM, Simon Horman
> > <horms+renesas@verge.net.au> wrote:
> > > From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> > >
> > > Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> > > [horms: minor updates]
> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> [snip]
>
> > Hi Simon,
> >
> > Thanks for your efforts with the ethernet controller. In general all
> > seems good to me, but this I came across the contents of this patch
> > when I was browsing the SoC DTSI file. What is the reason to put this
> > node in between dmac0 and dmac1? I don't know where is the best
> > location, but it would be good to keep the dmac nodes together I
> > think.
>
> I think its just an artifact of the way the patch has been updated.
> I'll see about cleaning it up.
On slightly closer inspection it seems to be there due to sorting
by base address. But it seems rather silly the way it is so I have it
in mind to shuffle it down below the dmac nodes.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v5 0/5] arm64: dts: r8a7795: enable EthernetAVB on Salvator-X
2015-10-15 6:48 [PATCH v5 0/5] arm64: dts: r8a7795: enable EthernetAVB on Salvator-X Simon Horman
` (5 preceding siblings ...)
2015-10-27 10:41 ` [PATCH v5 0/5] arm64: dts: r8a7795: enable EthernetAVB on Salvator-X Geert Uytterhoeven
@ 2015-11-20 1:22 ` Simon Horman
6 siblings, 0 replies; 11+ messages in thread
From: Simon Horman @ 2015-11-20 1:22 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 15, 2015 at 03:48:13PM +0900, Simon Horman wrote:
>
> This patchset enables the EthernetAVB on the Salvator-X board.
> With it and its dependencies in place I have have successfully
> booted to an nfsroot user-space (arm64 Debian Jessie).
I have queued this up for v4.5.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2015-11-20 1:22 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-15 6:48 [PATCH v5 0/5] arm64: dts: r8a7795: enable EthernetAVB on Salvator-X Simon Horman
2015-10-15 6:48 ` [PATCH v5 1/5] arm64: dts: r8a7795: add clock for EthernetAVB Simon Horman
2015-10-15 6:48 ` [PATCH v5 2/5] arm64: dts: r8a7795: add EthernetAVB device node Simon Horman
2015-10-29 8:42 ` Magnus Damm
2015-10-30 7:17 ` Simon Horman
2015-10-30 7:25 ` Simon Horman
2015-10-15 6:48 ` [PATCH v5 3/5] arm64: dts: r8a7795: enable EthernetAVB on Salvator-X Simon Horman
2015-10-15 6:48 ` [PATCH v5 4/5] arm64: dts: r8a7795: enable nfs root on Salvator-X board Simon Horman
2015-10-15 6:48 ` [PATCH v5 5/5] arm64: defconfig: enable EthernetAVB Simon Horman
2015-10-27 10:41 ` [PATCH v5 0/5] arm64: dts: r8a7795: enable EthernetAVB on Salvator-X Geert Uytterhoeven
2015-11-20 1:22 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox