[PATCH v2 14/15] ARM: shmobile: bockw dts: Move Ethernet node to BSC

[PATCH v2 14/15] ARM: shmobile: bockw dts: Move Ethernet node to BSC

[Ulrich Hecht]

Move the Ethernet node to the new BSC node, as its connected to the
Bus State Controller.

Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
 arch/arm/boot/dts/r8a7778-bockw.dts | 25 ++++++++++++++-----------
 1 file changed, 14 insertions(+), 11 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7778-bockw.dts b/arch/arm/boot/dts/r8a7778-bockw.dts
index 194ffbd..2b4b84b 100644
--- a/arch/arm/boot/dts/r8a7778-bockw.dts
+++ b/arch/arm/boot/dts/r8a7778-bockw.dts
@@ -46,17 +46,6 @@
 		regulator-always-on;
 	};
 
-	ethernet@18300000 {
-		compatible = "smsc,lan9220", "smsc,lan9115";
-		reg = <0x18300000 0x1000>;
-
-		phy-mode = "mii";
-		interrupt-parent = <&irqpin>;
-		interrupts = <0 IRQ_TYPE_EDGE_FALLING>;
-		reg-io-width = <4>;
-		vddvario-supply = <&fixedregulator3v3>;
-		vdd33a-supply = <&fixedregulator3v3>;
-	};
 
 	sound {
 		compatible = "simple-audio-card";
@@ -76,6 +65,20 @@
 	};
 };
 
+&bsc {
+	ethernet@18300000 {
+		compatible = "smsc,lan9220", "smsc,lan9115", "smsc,lan89218";
+		reg = <0x18300000 0x1000>;
+
+		phy-mode = "mii";
+		interrupt-parent = <&irqpin>;
+		interrupts = <0 IRQ_TYPE_EDGE_FALLING>;
+		reg-io-width = <4>;
+		vddvario-supply = <&fixedregulator3v3>;
+		vdd33a-supply = <&fixedregulator3v3>;
+	};
+};
+
 &ether {
 	pinctrl-0 = <&ether_pins>;
 	pinctrl-names = "default";
-- 
2.2.2

Re: [PATCH v2 14/15] ARM: shmobile: bockw dts: Move Ethernet node to BSC

[Geert Uytterhoeven]

On Mon, Feb 9, 2015 at 5:02 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> +&bsc {
> +       ethernet@18300000 {
> +               compatible = "smsc,lan9220", "smsc,lan9115", "smsc,lan89218";

The most specific (89218) compatible name should be listed first.
I think the 9220 entry is not required, so I'd use just

        compatible = "smsc,lan89218", "smsc,lan9115"

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2 14/15] ARM: shmobile: bockw dts: Move Ethernet node to BSC

[Laurent Pinchart]

Hello,

On Tuesday 10 February 2015 12:14:14 Geert Uytterhoeven wrote:
> On Mon, Feb 9, 2015 at 5:02 PM, Ulrich Hecht
> 
> <ulrich.hecht+renesas@gmail.com> wrote:
> > +&bsc {
> > +       ethernet@18300000 {
> > +               compatible = "smsc,lan9220", "smsc,lan9115",
> > "smsc,lan89218";
>
> The most specific (89218) compatible name should be listed first.
> I think the 9220 entry is not required, so I'd use just
> 
>         compatible = "smsc,lan89218", "smsc,lan9115"

The 9220 entry isn't required by the Linux driver as it detects the chip 
version at runtime. It could be useful for other operating systems (assuming, 
of course, that the 89218 implements features found in the 9220 but not in the 
9115), but I don't think we need to care too much about that as this is a .dts 
part of the Linux kernel sources and not a binding specification.

-- 
Regards,

Laurent Pinchart