From: "Sylwester Nawrocki" <s.nawrocki@samsung.com>
To: "'Marek Szyprowski'" <m.szyprowski@samsung.com>
Cc: "'Liam Girdwood'" <lgirdwood@gmail.com>,
"'Mark Brown'" <broonie@kernel.org>,
"'Charles Keepax'" <ckeepax@opensource.cirrus.com>,
"'Krzysztof Kozlowski'" <krzk@kernel.org>,
"'Simon Shields'" <simon@lineageos.org>,
"'Artur Weber'" <aweber.kernel@gmail.com>,
<patches@opensource.cirrus.com>, <linux-sound@vger.kernel.org>
Subject: RE: [PATCH 4/4] ASoC: samsung: midas_wm1811: run FLL1 at the AIF1 configured rate when idle
Date: Wed, 21 Oct 2026 17:31:11 +0200 [thread overview]
Message-ID: <000401dd6171$33dec8a0$9b9c59e0$@samsung.com> (raw)
In-Reply-To: <20261021101750.3297770-5-m.szyprowski@samsung.com>
> -----Original Message-----
> From: Marek Szyprowski <m.szyprowski@samsung.com>
[...]
> Subject: [PATCH 4/4] ASoC: samsung: midas_wm1811: run FLL1 at the AIF1
> configured rate when idle
>
> When the codec is brought up without an active stream, for example
> because the mixer state restored by alsactl powers up a digital path,
> midas_start_fll1() sets FLL1 to the default 11.2896MHz rate. The
> codec's AIF1 however keeps the configuration of the last stream, or its
> reset default of 48kHz at 256fs before the first stream, which needs
> a 12.288MHz AIF1 clock. The digital paths then run with AIF1 clocked
> at a rate not matching its configuration.
>
> Remember the FLL1 rate requested by the last hw_params() call, which
> matches the AIF1 configuration kept in the codec, and use it when no
> specific rate is requested. Change the default rate used before the
> first stream to 12.288MHz, matching the codec's default AIF1
> configuration.
>
> Fixes: fd0ea9cd9698 ("ASoC: samsung: Add sound support for Midas
> boards")
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
prev parent reply other threads:[~2026-10-21 15:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20261021101815eucas1p2f6dd40fb230ab01b36c7d8f3eada0f45@eucas1p2.samsung.com>
2026-10-21 10:17 ` [PATCH 0/4] ASoC: wm8994/midas_wm1811: fix codec clocking issues Marek Szyprowski
2026-10-21 10:17 ` [PATCH 1/4] ASoC: wm8994: fix MCLK gating for AIF clocks sourced from MCLK2 Marek Szyprowski
2026-10-21 14:39 ` Charles Keepax
2026-10-21 15:17 ` Sylwester Nawrocki
2026-10-21 15:24 ` Mark Brown
2026-10-21 10:17 ` [PATCH 2/4] ASoC: wm8994: don't lose the AIF clock ratio when staying at 32kHz SYSCLK Marek Szyprowski
2026-10-21 14:21 ` Charles Keepax
2026-10-21 15:22 ` Sylwester Nawrocki
2026-10-21 10:17 ` [PATCH 3/4] ASoC: wm8994: fix MCLK index used for setting MCLK rate Marek Szyprowski
2026-10-21 13:57 ` Charles Keepax
2026-10-21 15:23 ` Sylwester Nawrocki
2026-10-21 10:17 ` [PATCH 4/4] ASoC: samsung: midas_wm1811: run FLL1 at the AIF1 configured rate when idle Marek Szyprowski
2026-10-21 15:31 ` Sylwester Nawrocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000401dd6171$33dec8a0$9b9c59e0$@samsung.com' \
--to=s.nawrocki@samsung.com \
--cc=aweber.kernel@gmail.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=patches@opensource.cirrus.com \
--cc=simon@lineageos.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox