Re: [PATCH v2 10/19] ASoC: SDCA: Parse XU Entity properties

[Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>]

> +/**
> + * enum sdca_xu_reset_machanism - SDCA FDL Resets
> + */
> +enum sdca_xu_reset_mechanism {
> +	SDCA_XU_RESET_FUNCTION				= 0x0,
> +	SDCA_XU_RESET_DEVICE				= 0x1,
> +	SDCA_XU_RESET_BUS				= 0x2,
> +};

It'd be worth explaining how the last two might work? The RESET_BUS is puzzling, if the controller performs a hard reset then in theory the device should lose all context. Likewise a RESET_DEVICE should cause the SoundWire device to fall off the bus and lose context as well, and in the case of a multi-function device it could be fun if each function causes a device reset. This could end-up in a boot-loop, no?

> +static int find_sdca_entity_xu(struct device *dev,
> +			       struct fwnode_handle *entity_node,
> +			       struct sdca_entity *entity)
> +{
> +	struct sdca_entity_xu *xu = &entity->xu;
> +	u32 tmp;
> +	int ret;
> +
> +	ret = fwnode_property_read_u32(entity_node,
> +				       "mipi-sdca-RxUMP-ownership-transition-max-delay",
> +				       &tmp);
> +	if (!ret)
> +		xu->max_delay = tmp;

maybe add a sanity check on the value?

> +	ret = fwnode_property_read_u32(entity_node, "mipi-sdca-FDL-reset-mechanism",
> +				       &tmp);
> +	if (!ret)
> +		xu->reset_mechanism = tmp;

same here?

m