Re: [PATCH v2 07/19] ASoC: SDCA: Factor out a helper to find SDCA IRQ data

[Charles Keepax <ckeepax@opensource.cirrus.com>]

On Wed, Sep 17, 2025 at 08:49:17PM +0200, Pierre-Louis Bossart wrote:
> 
> > +static struct sdca_interrupt *get_interrupt_data(struct device *dev, int irq,
> > +						 struct sdca_interrupt_info *info)
> > +{
> > +	if (irq == SDCA_NO_INTERRUPT) {
> > +		return NULL;
> > +	} else if (irq < 0 || irq >= SDCA_MAX_INTERRUPTS) {
> > +		dev_err(dev, "bad irq position: %d\n", irq);
> > +		return ERR_PTR(-EINVAL);
> > +	}
> 
> Checking for the range isn't bad but could this be
> improved with the 'mipi-sdca-control-interrupt-position'
> DisCo properties?
> When parsing the DisCo data, we can probably come-up with
> a mask of valid interrupts, no?

I am not sure the check is appropriate here. This is simply
returning a data for a given irq number. Currently the two
users and both are directly requesting the IRQ numbers from
that interrupt-position property you mention, so really here
we are checking that those property values are within the
range of valid IRQs. Checking them against themself isn't
obviously helpful.

Thanks,
Charles