From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
Cc: broonie@kernel.org, rafael@kernel.org,
yung-chuan.liao@linux.intel.com, peter.ujfalusi@linux.intel.com,
shumingf@realtek.com, lgirdwood@gmail.com,
linux-sound@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH v2 09/19] ASoC: SDCA: Force some SDCA Controls to be volatile
Date: Thu, 18 Sep 2025 11:18:58 +0100 [thread overview]
Message-ID: <aMvckvvfNP86svKe@opensource.cirrus.com> (raw)
In-Reply-To: <893d6efb-14e4-4b1c-b114-dda207579bca@linux.dev>
On Wed, Sep 17, 2025 at 08:53:04PM +0200, Pierre-Louis Bossart wrote:
>
> > + switch (SDCA_CTL_TYPE(entity->type, control->sel)) {
> > + case SDCA_CTL_TYPE_S(XU, FDL_HOST_REQUEST):
> > + case SDCA_CTL_TYPE_S(XU, FDL_MESSAGEOFFSET):
> > + case SDCA_CTL_TYPE_S(XU, FDL_MESSAGELENGTH):
> > + case SDCA_CTL_TYPE_S(SPE, AUTHTX_MESSAGEOFFSET):
> > + case SDCA_CTL_TYPE_S(SPE, AUTHTX_MESSAGELENGTH):
> > + case SDCA_CTL_TYPE_S(SPE, AUTHRX_MESSAGEOFFSET):
> > + case SDCA_CTL_TYPE_S(SPE, AUTHRX_MESSAGELENGTH):
> > + case SDCA_CTL_TYPE_S(MFPU, AE_MESSAGEOFFSET):
> > + case SDCA_CTL_TYPE_S(MFPU, AE_MESSAGELENGTH):
> > + case SDCA_CTL_TYPE_S(SMPU, HIST_MESSAGEOFFSET):
> > + case SDCA_CTL_TYPE_S(SMPU, HIST_MESSAGELENGTH):
> > + case SDCA_CTL_TYPE_S(SMPU, DTODTX_MESSAGEOFFSET):
> > + case SDCA_CTL_TYPE_S(SMPU, DTODTX_MESSAGELENGTH):
> > + case SDCA_CTL_TYPE_S(SMPU, DTODRX_MESSAGEOFFSET):
> > + case SDCA_CTL_TYPE_S(SMPU, DTODRX_MESSAGELENGTH):
> > + case SDCA_CTL_TYPE_S(SAPU, DTODTX_MESSAGEOFFSET):
> > + case SDCA_CTL_TYPE_S(SAPU, DTODTX_MESSAGELENGTH):
> > + case SDCA_CTL_TYPE_S(SAPU, DTODRX_MESSAGEOFFSET):
> > + case SDCA_CTL_TYPE_S(SAPU, DTODRX_MESSAGELENGTH):
> > + case SDCA_CTL_TYPE_S(HIDE, HIDTX_MESSAGEOFFSET):
> > + case SDCA_CTL_TYPE_S(HIDE, HIDTX_MESSAGELENGTH):
> > + case SDCA_CTL_TYPE_S(HIDE, HIDRX_MESSAGEOFFSET):
> > + case SDCA_CTL_TYPE_S(HIDE, HIDRX_MESSAGELENGTH):
> > + case SDCA_CTL_TYPE_S(XU, FDL_STATUS):
> > + case SDCA_CTL_TYPE_S(XU, FDL_CURRENTOWNER):
> > + case SDCA_CTL_TYPE_S(SPE, AUTHTX_CURRENTOWNER):
> > + case SDCA_CTL_TYPE_S(SPE, AUTHRX_CURRENTOWNER):
> > + case SDCA_CTL_TYPE_S(MFPU, AE_CURRENTOWNER):
> > + case SDCA_CTL_TYPE_S(SMPU, HIST_CURRENTOWNER):
> > + case SDCA_CTL_TYPE_S(SMPU, DTODTX_CURRENTOWNER):
> > + case SDCA_CTL_TYPE_S(SMPU, DTODRX_CURRENTOWNER):
> > + case SDCA_CTL_TYPE_S(SAPU, DTODTX_CURRENTOWNER):
> > + case SDCA_CTL_TYPE_S(SAPU, DTODRX_CURRENTOWNER):
> > + case SDCA_CTL_TYPE_S(HIDE, HIDTX_CURRENTOWNER):
> > + case SDCA_CTL_TYPE_S(HIDE, HIDRX_CURRENTOWNER):
>
> Maybe reorder these cases by entity type? or by control
> selector? The list above is a mix that doesn't seem very
> logical to me.
Yeah I will reorder by entity.
Thanks,
Charles
next prev parent reply other threads:[~2025-09-18 10:19 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 10:34 [PATCH v2 00/20] Add SDCA UMP/FDL support Charles Keepax
2025-09-12 10:34 ` [PATCH v2 01/19] ASoC: SDCA: Rename SoundWire struct device variables Charles Keepax
2025-09-12 10:34 ` [PATCH v2 02/19] regmap: sdw-mbq: Don't assume the regmap device is the SoundWire slave Charles Keepax
2025-09-12 10:34 ` [PATCH v2 03/19] ASoC: SDCA: Add manual PM runtime gets to IRQ handlers Charles Keepax
2025-09-12 10:34 ` [PATCH v2 04/19] ASoC: SDCA: Pass SoundWire slave to HID Charles Keepax
2025-09-12 10:34 ` [PATCH v2 05/19] ASoC: SDCA: Pass device register map from IRQ alloc to handlers Charles Keepax
2025-09-12 10:34 ` [PATCH v2 06/19] ASoC: SDCA: Update externally_requested flag to cover all requests Charles Keepax
2025-09-12 10:34 ` [PATCH v2 07/19] ASoC: SDCA: Factor out a helper to find SDCA IRQ data Charles Keepax
2025-09-17 18:49 ` Pierre-Louis Bossart
2025-09-19 10:41 ` Charles Keepax
2025-09-12 10:34 ` [PATCH v2 08/19] ASoC: SDCA: Rely less on the ASoC component in IRQ handling Charles Keepax
2025-09-12 10:34 ` [PATCH v2 09/19] ASoC: SDCA: Force some SDCA Controls to be volatile Charles Keepax
2025-09-17 18:53 ` Pierre-Louis Bossart
2025-09-18 10:18 ` Charles Keepax [this message]
2025-09-12 10:34 ` [PATCH v2 10/19] ASoC: SDCA: Parse XU Entity properties Charles Keepax
2025-09-17 18:58 ` Pierre-Louis Bossart
2025-09-18 10:24 ` Charles Keepax
2025-09-12 10:34 ` [PATCH v2 11/19] ASoC: SDCA: Parse Function Reset max delay Charles Keepax
2025-09-12 10:34 ` [PATCH v2 12/19] ASoC: SDCA: Add UMP buffer helper functions Charles Keepax
2025-09-17 19:49 ` Pierre-Louis Bossart
2025-09-18 12:22 ` Charles Keepax
2025-09-12 10:34 ` [PATCH v2 13/19] ASoC: SDCA: Add SDCA FDL data parsing Charles Keepax
2025-09-16 13:38 ` Mark Brown
2025-09-16 13:45 ` Mark Brown
2025-09-16 13:51 ` Charles Keepax
2025-09-17 12:14 ` Mark Brown
2025-09-17 14:31 ` Charles Keepax
2025-09-18 20:25 ` Mark Brown
2025-09-19 8:06 ` Charles Keepax
2025-09-12 10:34 ` [PATCH v2 14/19] ASoC: SDCA: Add FDL library for XU entities Charles Keepax
2025-09-12 10:35 ` [PATCH v2 15/19] ASoC: SDCA: Add FDL-specific IRQ processing Charles Keepax
2025-09-12 10:35 ` [PATCH v2 16/19] ASoC: SDCA: Add completion for FDL start and stop Charles Keepax
2025-09-17 20:13 ` Pierre-Louis Bossart
2025-09-18 10:57 ` Charles Keepax
2025-09-12 10:35 ` [PATCH v2 17/19] ASoC: SDCA: Add UMP timeout handling for FDL Charles Keepax
2025-09-12 10:35 ` [PATCH v2 18/19] ASoC: SDCA: Add early IRQ handling Charles Keepax
2025-09-12 10:35 ` [PATCH v2 19/19] ASoC: SDCA: Add HID button IRQ Charles Keepax
2025-09-16 2:12 ` [PATCH v2 00/20] Add SDCA UMP/FDL support Liao, Bard
2025-09-17 20:20 ` Pierre-Louis Bossart
2025-10-29 22:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMvckvvfNP86svKe@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=rafael@kernel.org \
--cc=shumingf@realtek.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox