[PATCH] soc: qcom: fix unmet dependency for QCOM_PDR_MSG

[PATCH] soc: qcom: fix unmet dependency for QCOM_PDR_MSG

[Julian Braha]

QCOM_PDR_MSG is defined in an 'if QCOM_SOC..endif', so its selectors
QCOM_PDR_HELPERS and SLIM_QCOM_NGD_CTRL also need to ensure QCOM_SOC is
enabled. Otherwise, QCOM_PDR_MSG has an unmet dependency, such as:

WARNING: unmet direct dependencies detected for QCOM_PDR_MSG
  Depends on [n]: QCOM_SOC [=n]
  Selected by [y]:
  - QCOM_PDR_HELPERS [=y] && ARCH_QCOM [=y] && NET [=y]

This unmet dependency was found by kconfirm, a static analysis tool for
Kconfig.

Fixes: f2866e6a27f7 ("soc: qcom: Hide all drivers behind selectable menu")
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
 drivers/slimbus/Kconfig  | 2 +-
 drivers/soc/qcom/Kconfig | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig
index 60b0dcbc0ebb..5dded61191e0 100644
--- a/drivers/slimbus/Kconfig
+++ b/drivers/slimbus/Kconfig
@@ -17,7 +17,7 @@ config SLIM_QCOM_NGD_CTRL
 	tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component"
 	depends on HAS_IOMEM && DMA_ENGINE && NET
 	depends on QCOM_RPROC_COMMON || (COMPILE_TEST && !QCOM_RPROC_COMMON)
-	depends on ARCH_QCOM || COMPILE_TEST
+	depends on QCOM_SOC && (ARCH_QCOM || COMPILE_TEST)
 	select QCOM_QMI_HELPERS
 	select QCOM_PDR_HELPERS
 	help
diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
index fd4d4ecd2df0..ef844947593c 100644
--- a/drivers/soc/qcom/Kconfig
+++ b/drivers/soc/qcom/Kconfig
@@ -292,7 +292,7 @@ config QCOM_PBS
 	  This module provides the APIs to the client drivers that wants to send the
 	  PBS trigger event to the PBS RAM.
 
-endif
+endif # QCOM_SOC
 
 # Options selected by other drivers from different subsystems must be outside
 # of the menuconfig if-block:
@@ -314,6 +314,7 @@ config QCOM_PDR_HELPERS
 	select QCOM_QMI_HELPERS
 	select QCOM_PDR_MSG
 	depends on NET
+	depends on QCOM_SOC
 
 config QCOM_QMI_HELPERS
 	tristate
-- 
2.54.0

Re: [PATCH] soc: qcom: fix unmet dependency for QCOM_PDR_MSG

[Dmitry Baryshkov]

On Sun, Jul 19, 2026 at 03:22:41AM +0100, Julian Braha wrote:
> QCOM_PDR_MSG is defined in an 'if QCOM_SOC..endif', so its selectors
> QCOM_PDR_HELPERS and SLIM_QCOM_NGD_CTRL also need to ensure QCOM_SOC is
> enabled. Otherwise, QCOM_PDR_MSG has an unmet dependency, such as:
> 
> WARNING: unmet direct dependencies detected for QCOM_PDR_MSG
>   Depends on [n]: QCOM_SOC [=n]
>   Selected by [y]:
>   - QCOM_PDR_HELPERS [=y] && ARCH_QCOM [=y] && NET [=y]
> 
> This unmet dependency was found by kconfirm, a static analysis tool for
> Kconfig.
> 
> Fixes: f2866e6a27f7 ("soc: qcom: Hide all drivers behind selectable menu")

I don't see this commit in linux-next

> Signed-off-by: Julian Braha <julianbraha@gmail.com>
> ---
>  drivers/slimbus/Kconfig  | 2 +-
>  drivers/soc/qcom/Kconfig | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig
> index 60b0dcbc0ebb..5dded61191e0 100644
> --- a/drivers/slimbus/Kconfig
> +++ b/drivers/slimbus/Kconfig
> @@ -17,7 +17,7 @@ config SLIM_QCOM_NGD_CTRL
>  	tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component"
>  	depends on HAS_IOMEM && DMA_ENGINE && NET
>  	depends on QCOM_RPROC_COMMON || (COMPILE_TEST && !QCOM_RPROC_COMMON)
> -	depends on ARCH_QCOM || COMPILE_TEST
> +	depends on QCOM_SOC && (ARCH_QCOM || COMPILE_TEST)

This defeats the purpose of COMPILE_TEST.

>  	select QCOM_QMI_HELPERS
>  	select QCOM_PDR_HELPERS
>  	help

-- 
With best wishes
Dmitry

Re: [PATCH] soc: qcom: fix unmet dependency for QCOM_PDR_MSG

[Arnd Bergmann]

On Wed, Jul 22, 2026, at 15:47, Dmitry Baryshkov wrote:
>> diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig
>> index 60b0dcbc0ebb..5dded61191e0 100644
>> --- a/drivers/slimbus/Kconfig
>> +++ b/drivers/slimbus/Kconfig
>> @@ -17,7 +17,7 @@ config SLIM_QCOM_NGD_CTRL
>>  	tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component"
>>  	depends on HAS_IOMEM && DMA_ENGINE && NET
>>  	depends on QCOM_RPROC_COMMON || (COMPILE_TEST && !QCOM_RPROC_COMMON)
>> -	depends on ARCH_QCOM || COMPILE_TEST
>> +	depends on QCOM_SOC && (ARCH_QCOM || COMPILE_TEST)
>
> This defeats the purpose of COMPILE_TEST.

The '(ARCH_QCOM || COMPILE_TEST)' is probably not even helpful
here because QCOM_SOC also depends on that.

     Arnd

Re: [PATCH] soc: qcom: fix unmet dependency for QCOM_PDR_MSG

[Julian Braha]

On 7/22/26 14:54, Arnd Bergmann wrote:
> The '(ARCH_QCOM || COMPILE_TEST)' is probably not even helpful
> here because QCOM_SOC also depends on that.

Nice catch, thanks Arnd. Will send a v2.

- Julian Braha

Re: [PATCH] soc: qcom: fix unmet dependency for QCOM_PDR_MSG

[Julian Braha]

Hi Dmitry,

On 7/22/26 14:47, Dmitry Baryshkov wrote:
> I don't see this commit in linux-next

You can see it here:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=f2866e6a27f7cc26111ce195ddf00d4050bb27e5

- Julian Braha