* [PATCH] ASoC: ti: omap-hdmi: Fix too long driver name
@ 2024-06-06 7:06 Primoz Fiser
2024-06-06 18:00 ` Péter Ujfalusi
0 siblings, 1 reply; 5+ messages in thread
From: Primoz Fiser @ 2024-06-06 7:06 UTC (permalink / raw)
To: Peter Ujfalusi, Jarkko Nikula, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-omap,
linux-sound, linux-kernel
Cc: upstream
Set driver name to DRV_NAME. This simplifies the code and gets rid of
the following error messages:
ASoC: driver name too long 'HDMI 58040000.encoder' -> 'HDMI_58040000_e'
Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
---
sound/soc/ti/omap-hdmi.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/sound/soc/ti/omap-hdmi.c b/sound/soc/ti/omap-hdmi.c
index 639bc83f4263..3f35eedeea41 100644
--- a/sound/soc/ti/omap-hdmi.c
+++ b/sound/soc/ti/omap-hdmi.c
@@ -354,11 +354,7 @@ static int omap_hdmi_audio_probe(struct platform_device *pdev)
if (!card)
return -ENOMEM;
- card->name = devm_kasprintf(dev, GFP_KERNEL,
- "HDMI %s", dev_name(ad->dssdev));
- if (!card->name)
- return -ENOMEM;
-
+ card->name = DRV_NAME;
card->owner = THIS_MODULE;
card->dai_link =
devm_kzalloc(dev, sizeof(*(card->dai_link)), GFP_KERNEL);
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: ti: omap-hdmi: Fix too long driver name
2024-06-06 7:06 [PATCH] ASoC: ti: omap-hdmi: Fix too long driver name Primoz Fiser
@ 2024-06-06 18:00 ` Péter Ujfalusi
2024-06-06 18:01 ` Mark Brown
0 siblings, 1 reply; 5+ messages in thread
From: Péter Ujfalusi @ 2024-06-06 18:00 UTC (permalink / raw)
To: Primoz Fiser, Jarkko Nikula, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-omap,
linux-sound, linux-kernel
Cc: upstream
On 6/6/24 10:06 AM, Primoz Fiser wrote:
> Set driver name to DRV_NAME. This simplifies the code and gets rid of
> the following error messages:
>
> ASoC: driver name too long 'HDMI 58040000.encoder' -> 'HDMI_58040000_e'
>
> Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
> ---
> sound/soc/ti/omap-hdmi.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/sound/soc/ti/omap-hdmi.c b/sound/soc/ti/omap-hdmi.c
> index 639bc83f4263..3f35eedeea41 100644
> --- a/sound/soc/ti/omap-hdmi.c
> +++ b/sound/soc/ti/omap-hdmi.c
> @@ -354,11 +354,7 @@ static int omap_hdmi_audio_probe(struct platform_device *pdev)
> if (!card)
> return -ENOMEM;
>
> - card->name = devm_kasprintf(dev, GFP_KERNEL,
> - "HDMI %s", dev_name(ad->dssdev));
> - if (!card->name)
> - return -ENOMEM;
> -
> + card->name = DRV_NAME;
I think it would be better to name is simply "HDMI" instead
> card->owner = THIS_MODULE;
> card->dai_link =
> devm_kzalloc(dev, sizeof(*(card->dai_link)), GFP_KERNEL);
--
Péter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: ti: omap-hdmi: Fix too long driver name
2024-06-06 18:00 ` Péter Ujfalusi
@ 2024-06-06 18:01 ` Mark Brown
2024-06-07 6:14 ` Primoz Fiser
0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2024-06-06 18:01 UTC (permalink / raw)
To: Péter Ujfalusi
Cc: Primoz Fiser, Jarkko Nikula, Liam Girdwood, Jaroslav Kysela,
Takashi Iwai, alsa-devel, linux-omap, linux-sound, linux-kernel,
upstream
[-- Attachment #1: Type: text/plain, Size: 404 bytes --]
On Thu, Jun 06, 2024 at 09:00:47PM +0300, Péter Ujfalusi wrote:
> On 6/6/24 10:06 AM, Primoz Fiser wrote:
> > - card->name = devm_kasprintf(dev, GFP_KERNEL,
> > - "HDMI %s", dev_name(ad->dssdev));
> > - if (!card->name)
> > - return -ENOMEM;
> > -
> > + card->name = DRV_NAME;
> I think it would be better to name is simply "HDMI" instead
That does seem a bit more user friendly.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: ti: omap-hdmi: Fix too long driver name
2024-06-06 18:01 ` Mark Brown
@ 2024-06-07 6:14 ` Primoz Fiser
2024-06-07 15:43 ` Mark Brown
0 siblings, 1 reply; 5+ messages in thread
From: Primoz Fiser @ 2024-06-07 6:14 UTC (permalink / raw)
To: Mark Brown, Péter Ujfalusi
Cc: Jarkko Nikula, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
alsa-devel, linux-omap, linux-sound, linux-kernel, upstream
Hi,
On 6. 06. 24 20:01, Mark Brown wrote:
> On Thu, Jun 06, 2024 at 09:00:47PM +0300, Péter Ujfalusi wrote:
>> On 6/6/24 10:06 AM, Primoz Fiser wrote:
>
>>> - card->name = devm_kasprintf(dev, GFP_KERNEL,
>>> - "HDMI %s", dev_name(ad->dssdev));
>>> - if (!card->name)
>>> - return -ENOMEM;
>>> -
>>> + card->name = DRV_NAME;
>
>> I think it would be better to name is simply "HDMI" instead
>
> That does seem a bit more user friendly.
So card->name = "HDMI" for v2?
Thanks,
BR,
Primoz
--
Primoz Fiser | phone: +386-41-390-545
<tel:+386-41-390-545> |
---------------------------------------------------------|
Norik systems d.o.o. | https://www.norik.com
<https://www.norik.com> |
Your embedded software partner | email: info@norik.com
<mailto:info@norik.com> |
Slovenia, EU | phone: +386-41-540-545
<tel:+386-41-540-545> |
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: ti: omap-hdmi: Fix too long driver name
2024-06-07 6:14 ` Primoz Fiser
@ 2024-06-07 15:43 ` Mark Brown
0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2024-06-07 15:43 UTC (permalink / raw)
To: Primoz Fiser
Cc: Péter Ujfalusi, Jarkko Nikula, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-omap,
linux-sound, linux-kernel, upstream
[-- Attachment #1: Type: text/plain, Size: 110 bytes --]
On Fri, Jun 07, 2024 at 08:14:40AM +0200, Primoz Fiser wrote:
> So card->name = "HDMI" for v2?
Yes, please.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-06-07 15:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-06 7:06 [PATCH] ASoC: ti: omap-hdmi: Fix too long driver name Primoz Fiser
2024-06-06 18:00 ` Péter Ujfalusi
2024-06-06 18:01 ` Mark Brown
2024-06-07 6:14 ` Primoz Fiser
2024-06-07 15:43 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox