[PATCH] ASoC: tegra: select CONFIG_SND_SIMPLE_CARD_UTILS

[PATCH] ASoC: tegra: select CONFIG_SND_SIMPLE_CARD_UTILS

[Arnd Bergmann]

From: Arnd Bergmann <arnd@arndb.de>

This I2S client driver now uses functions exported from a helper module
but fails to link when the helper is disabled:

ERROR: modpost: "simple_util_parse_convert" [sound/soc/tegra/snd-soc-tegra210-i2s.ko] undefined!
ERROR: modpost: "simple_util_get_sample_fmt" [sound/soc/tegra/snd-soc-tegra210-i2s.ko] undefined!

Add a Kconfig select line to ensure it's always turned on here.

Fixes: 2502f8dd8c30 ("ASoC: tegra: I2S client convert formats handling")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 sound/soc/tegra/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/tegra/Kconfig b/sound/soc/tegra/Kconfig
index 74effc57a7a0..2463c22e9cf6 100644
--- a/sound/soc/tegra/Kconfig
+++ b/sound/soc/tegra/Kconfig
@@ -78,6 +78,7 @@ config SND_SOC_TEGRA210_DMIC
 
 config SND_SOC_TEGRA210_I2S
 	tristate "Tegra210 I2S module"
+	select SND_SIMPLE_CARD_UTILS
 	help
 	  Config to enable the Inter-IC Sound (I2S) Controller which
 	  implements full-duplex and bidirectional and single direction
-- 
2.39.2

Re: [PATCH] ASoC: tegra: select CONFIG_SND_SIMPLE_CARD_UTILS

[Sameer Pujar]

On 19-07-2024 13:18, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This I2S client driver now uses functions exported from a helper module
> but fails to link when the helper is disabled:
>
> ERROR: modpost: "simple_util_parse_convert" [sound/soc/tegra/snd-soc-tegra210-i2s.ko] undefined!
> ERROR: modpost: "simple_util_get_sample_fmt" [sound/soc/tegra/snd-soc-tegra210-i2s.ko] undefined!
>
> Add a Kconfig select line to ensure it's always turned on here.
>
> Fixes: 2502f8dd8c30 ("ASoC: tegra: I2S client convert formats handling")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   sound/soc/tegra/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>

Thanks for the fix.

Reviewed-by: Sameer Pujar <spujar@nvidia.com>

Re: [PATCH] ASoC: tegra: select CONFIG_SND_SIMPLE_CARD_UTILS

[Mark Brown]

On Fri, 19 Jul 2024 09:48:03 +0200, Arnd Bergmann wrote:
> This I2S client driver now uses functions exported from a helper module
> but fails to link when the helper is disabled:
> 
> ERROR: modpost: "simple_util_parse_convert" [sound/soc/tegra/snd-soc-tegra210-i2s.ko] undefined!
> ERROR: modpost: "simple_util_get_sample_fmt" [sound/soc/tegra/snd-soc-tegra210-i2s.ko] undefined!
> 
> Add a Kconfig select line to ensure it's always turned on here.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: tegra: select CONFIG_SND_SIMPLE_CARD_UTILS
      commit: 83340b855d222f257354afd272dc8d315fecc3ee

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark