* [PATCH 1/2] sounds: firewire: isight: changed strcpy to strscpy
@ 2025-02-05 19:22 jack Livingood
2025-02-06 0:26 ` Takashi Sakamoto
2025-02-10 17:10 ` Takashi Iwai
0 siblings, 2 replies; 3+ messages in thread
From: jack Livingood @ 2025-02-05 19:22 UTC (permalink / raw)
To: clemens; +Cc: o-takashi, linux-sound, Jack Livingood
From: Jack Livingood <jacklivingood@comcast.net>
changed strcpy to strscpy in order to prevent a possible linear
overflow.
Signed-off-by: Jack Livingood <jacklivingood@comcast.net>
---
sound/firewire/isight.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/firewire/isight.c b/sound/firewire/isight.c
index 806f82c9ceee..e9617fc0a532 100644
--- a/sound/firewire/isight.c
+++ b/sound/firewire/isight.c
@@ -637,13 +637,13 @@ static int isight_probe(struct fw_unit *unit,
card->private_free = isight_card_free;
- strcpy(card->driver, "iSight");
- strcpy(card->shortname, "Apple iSight");
+ strscpy(card->driver, "iSight");
+ strscpy(card->shortname, "Apple iSight");
snprintf(card->longname, sizeof(card->longname),
"Apple iSight (GUID %08x%08x) at %s, S%d",
fw_dev->config_rom[3], fw_dev->config_rom[4],
dev_name(&unit->device), 100 << fw_dev->max_speed);
- strcpy(card->mixername, "iSight");
+ strspy(card->mixername, "iSight");
err = isight_create_pcm(isight);
if (err < 0)
--
2.48.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] sounds: firewire: isight: changed strcpy to strscpy
2025-02-05 19:22 [PATCH 1/2] sounds: firewire: isight: changed strcpy to strscpy jack Livingood
@ 2025-02-06 0:26 ` Takashi Sakamoto
2025-02-10 17:10 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Sakamoto @ 2025-02-06 0:26 UTC (permalink / raw)
To: tiwai, jack Livingood; +Cc: linux-sound
Hi,
On Wed, Feb 05, 2025 at 11:22:58AM -0800, jack Livingood wrote:
> From: Jack Livingood <jacklivingood@comcast.net>
>
> changed strcpy to strscpy in order to prevent a possible linear
> overflow.
>
> Signed-off-by: Jack Livingood <jacklivingood@comcast.net>
> ---
> sound/firewire/isight.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Looks good to me.
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Thanks
Takashi Sakamoto
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] sounds: firewire: isight: changed strcpy to strscpy
2025-02-05 19:22 [PATCH 1/2] sounds: firewire: isight: changed strcpy to strscpy jack Livingood
2025-02-06 0:26 ` Takashi Sakamoto
@ 2025-02-10 17:10 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2025-02-10 17:10 UTC (permalink / raw)
To: jack Livingood; +Cc: clemens, o-takashi, linux-sound
On Wed, 05 Feb 2025 20:22:58 +0100,
jack Livingood wrote:
>
> From: Jack Livingood <jacklivingood@comcast.net>
>
> changed strcpy to strscpy in order to prevent a possible linear
> overflow.
>
> Signed-off-by: Jack Livingood <jacklivingood@comcast.net>
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-10 17:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-05 19:22 [PATCH 1/2] sounds: firewire: isight: changed strcpy to strscpy jack Livingood
2025-02-06 0:26 ` Takashi Sakamoto
2025-02-10 17:10 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox