Re: [PATCH 04/23] ASoC: soc-compress: Implement trigger FE-BE sequencing as with normal PCMs

[Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>]

On 9/7/26 07:25, Péter Ujfalusi wrote:
> 
> 
> On 04/09/2026 22:45, Mark Brown wrote:
>> On Fri, Sep 04, 2026 at 10:31:15AM +0300, Peter Ujfalusi wrote:
>>
>>> The FE-BE trigger sequence should be dynamic, similarly how soc-pcm.c
>>> dpcm_fe_dai_do_trigger() does it.
>>
>>> +static int soc_compr_trigger_fe(struct snd_compr_stream *cstream, int cmd)
>>> +{
>>> +	struct snd_soc_pcm_runtime *fe = cstream->private_data;
>>>  	int stream = cstream->direction; /* SND_COMPRESS_xxx is same as SNDRV_PCM_STREAM_xxx */
>>> +	bool fe_first;
>>>  	int ret;
>>>  
>>>  	if (cmd == SND_COMPR_TRIGGER_PARTIAL_DRAIN ||
>>>  	    cmd == SND_COMPR_TRIGGER_DRAIN)
>>>  		return snd_soc_component_compr_trigger(cstream, cmd);
>>
>> What about SND_COMPR_TRIGGER_NEXT_TRACK...
> 
> That was already missing in the initial patch which added the DPCM
> support for compress.
> 
>>
>>> +	switch (cmd) {
>>> +	case SNDRV_PCM_TRIGGER_START:
>>> +	case SNDRV_PCM_TRIGGER_RESUME:
>>> +	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
>>> +		ret = soc_compr_trigger_fe_be(cstream, cmd, fe_first);
>>> +		break;
>>> +	case SNDRV_PCM_TRIGGER_STOP:
>>> +	case SNDRV_PCM_TRIGGER_SUSPEND:
>>> +	case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
>>> +		ret = soc_compr_trigger_fe_be(cstream, cmd, !fe_first);
>>> +		break;
>>> +	default:
>>> +		ret = -EINVAL;
>>> +		break;
>>
>> ...otherwise it'll end up with -EINVAL instead of getting passed
>> through.  Also a switch statement would be a bit more idiomatic.
> 
> OK, I will add the NEXT_TRACK and convert the if to switch.

ICYMI for testing, NEXT_TRACK and PARTIAL_DRAIN are only enabled in the
'fcplay' application with the '-p 1' argument for gapless playback, not
in the initial cplay application.