Re: [PATCH 01/23] ALSA: compress: pin card module while stream is open

["Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>]

On 04/09/2026 10:50, Takashi Iwai wrote:
> On Fri, 04 Sep 2026 09:31:12 +0200,
> Peter Ujfalusi wrote:
>>
>> Take a module reference in snd_compr_open() and release it in
>> snd_compr_free(). This pins the card driver module for the
>> lifetime of an open compress stream and prevents card removal
>> while the stream file is still in use.
>>
>> Adjust the open() cleanup paths to drop the added module
>> reference only when it was acquired, and keep release ordering
>> safe by dropping the module reference before freeing stream
>> data.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
>> Reviewed-by: Liam Girdwood <liam.r.girdwood@intel.com>
> 
> Reviewed-by: Takashi Iwai <tiwai@suse.de>
> 
> While we're at it: the compress-offload seems missing the call of
> snd_card_file_add() and snd_card_file_remove() at open/close, too.
> By adding those, the unexpected syscalls are guarded in the core side
> after disconnection by replacing file ops.

You are right, I'll prepare the followup patch and either send it later
or include it in v2 of the series.

-- 
Péter