Re: [PATCH 19/23] ASoC: SOF: Add support for IPC4 compressed

["Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>]

On 07/09/2026 08:15, Péter Ujfalusi wrote:
> 
> 
> On 04/09/2026 23:08, Mark Brown wrote:
>> On Fri, Sep 04, 2026 at 10:31:30AM +0300, Peter Ujfalusi wrote:
>>> Set and define the compressed ops for IPC4.
>>> The initial implementation supports basic features: PAUSE PUSH/RELEASE,
>>> DRAIN and progress reporting.
>>> Tested with PCM, MP3, AAC and VORBIS codec.
>>
>>> +static int sof_ipc4_compr_set_params(struct snd_soc_component *component,
>>> +				     struct snd_compr_stream *cstream,
>>> +				     struct snd_compr_params *params)
>>> +{
>>
>>> +	/* Use correct format based on the used codec */
>>> +	switch (params->codec.id) {
>>> +	case SND_AUDIOCODEC_PCM:
>>> +		snd_mask_set_format(fmt, (snd_pcm_format_t)params->codec.format);
>>> +		break;
>>
>> Do we validate the value supplied by userspace here?
> 
> On SOF core side we do not, but on the Intel side in
> hda_dsp_compr_hw_params() we might want to fail in case of S24_3LE,
> which is not supported. by hardware.

On a second thought, this is not needed either, we will reject formats
based on the topology information

-- 
Péter