From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kiseok Jo <kiseok.jo@irondevice.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
devicetree@vger.kernel.org, application@irondevice.com
Subject: Re: [PATCH v2 1/3] ASoC: sma1307: Add driver for Iron Device SMA1307
Date: Tue, 3 Sep 2024 08:58:19 +0200 [thread overview]
Message-ID: <6648b7d3-3883-4d48-9b71-b8394a84fda5@kernel.org> (raw)
In-Reply-To: <3gu6u7euavq272kaf2znmyn5p3rd3vupvqldvfxnq7nh5ul6jx@apwfcxvgkoyj>
On 03/09/2024 08:57, Krzysztof Kozlowski wrote:
> On Tue, Sep 03, 2024 at 02:44:33PM +0900, Kiseok Jo wrote:
>> Signed-off-by: Kiseok Jo <kiseok.jo@irondevice.com>
>> ---
>> sound/soc/codecs/Kconfig | 8 +
...
>
>> + if (ret) {
>> + dev_err(&client->dev, "%s: failed to register component\n",
>> + __func__);
>> +
>> + return ret;
>> + }
>> +
>> + sma1307->attr_grp = &sma1307_attr_group;
>> + ret = sysfs_create_group(sma1307->kobj, sma1307->attr_grp);
>
> Where is sysfs ABI documented?
>
Ah, now I see your sysfs ABI documentation, but you ordered patches
incorrectly. Documentation comes before its usage.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-03 6:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 5:44 [PATCH v2 0/3] Add a driver for the Iron Device SMA1307 Amp Kiseok Jo
2024-09-03 5:44 ` [PATCH v2 1/3] ASoC: sma1307: Add driver for Iron Device SMA1307 Kiseok Jo
2024-09-03 6:57 ` Krzysztof Kozlowski
2024-09-03 6:58 ` Krzysztof Kozlowski [this message]
2024-09-03 7:57 ` Ki-Seok Jo
2024-09-03 8:15 ` Krzysztof Kozlowski
2024-09-03 8:33 ` Ki-Seok Jo
2024-09-03 8:51 ` Krzysztof Kozlowski
2024-09-03 15:57 ` kernel test robot
2024-09-03 18:12 ` Mark Brown
2024-09-12 8:35 ` Ki-Seok Jo
2024-09-12 11:23 ` Mark Brown
2024-09-03 5:44 ` [PATCH v2 2/3] ASoC: dt-bindings: irondevice,sma1307: Add initial DT binding Kiseok Jo
2024-09-03 6:49 ` Krzysztof Kozlowski
2024-09-03 8:39 ` Ki-Seok Jo
2024-09-03 8:55 ` Krzysztof Kozlowski
2024-09-03 9:08 ` Ki-Seok Jo
2024-09-03 9:14 ` Krzysztof Kozlowski
2024-09-03 13:39 ` Mark Brown
2024-09-11 1:16 ` FW: " Ki-Seok Jo
2024-09-11 18:26 ` Conor Dooley
2024-09-12 0:25 ` Ki-Seok Jo
2024-09-03 5:44 ` [PATCH v2 3/3] doc: ABI: testing: sma1307: Add support for SMA1307 Kiseok Jo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6648b7d3-3883-4d48-9b71-b8394a84fda5@kernel.org \
--to=krzk@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=application@irondevice.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kiseok.jo@irondevice.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox