Re: [PATCH v2 1/3] ASoC: sma1307: Add driver for Iron Device SMA1307

[Krzysztof Kozlowski <krzk@kernel.org>]

On 03/09/2024 09:57, Ki-Seok Jo wrote:
>> On 03/09/2024 08:57, Krzysztof Kozlowski wrote:
>>> On Tue, Sep 03, 2024 at 02:44:33PM +0900, Kiseok Jo wrote:
>>>> Signed-off-by: Kiseok Jo <kiseok.jo@irondevice.com>
>>>> ---
>>>>  sound/soc/codecs/Kconfig   |    8 +
>>
>> ...
>>
>>>
>>>> +	if (ret) {
>>>> +		dev_err(&client->dev, "%s: failed to register component\n",
>>>> +			__func__);
>>>> +
>>>> +		return ret;
>>>> +	}
>>>> +
>>>> +	sma1307->attr_grp = &sma1307_attr_group;
>>>> +	ret = sysfs_create_group(sma1307->kobj, sma1307->attr_grp);
>>>
>>> Where is sysfs ABI documented?
>>>
>>
>> Ah, now I see your sysfs ABI documentation, but you ordered patches
>> incorrectly. Documentation comes before its usage.
>>
>> Best regards,
>> Krzysztof
> 
> 
> Okay!
> I have currently submitted 3 patches in the following order: 
> first, I registered the device driver, then the dt-binding, and finally the sysfs ABI documentation.
> 
> I'll submit the ABI documentation first. Should the dt-binding also be submitted before the driver?
> 

Yes, ABI goes before the user. See writing-bindings document.


Best regards,
Krzysztof