Re: [PATCH v2 2/3] ASoC: dt-bindings: irondevice,sma1307: Add initial DT binding

[Krzysztof Kozlowski <krzk@kernel.org>]

On 03/09/2024 10:39, Ki-Seok Jo wrote:
>>
>> On Tue, Sep 03, 2024 at 02:44:34PM +0900, Kiseok Jo wrote:
>>> Signed-off-by: Kiseok Jo <kiseok.jo@irondevice.com>
>>
>> Empty commit? Read submitting-patches.
>>
> 
> Okay I'll add next patch.
> 
> 
>> Please run scripts/checkpatch.pl and fix reported warnings. Then please run
>> and (probably) fix more warnings.
>> Some warnings can be ignored, especially from --strict run, but the code here
>> looks like it needs a fix. Feel free to get in touch if the warning is not
>> clear.
>>
> 
> When I checked, I didn't encounter any errors or warnings when using 'checkpatch.pl'.
> What options might be needed?

That's not true and I am not happy that I need to prove to you obvious
thing. You do not need any options. Look:

WARNING: Missing commit description - Add an appropriate one

You could at least now double check if reviewer pointed it out instead
of immediately disagreeing with review.

> 
> 
>>> ---
>>
>> Where is the changelog? What happened in v2? Why are you sending the same
>> patch?
>>
> 
> I understand that the file has not been applied yet, so it needs to be rewritten again until applied.
> 

Read submitting patches.

Best regards,
Krzysztof