Re: [PATCH v2 2/4] ASoC: SDCA: Add basic system suspend support

[Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>]

>>>>> +	ret = pm_runtime_force_suspend(dev);
>>>>> +	if (ret) {
>>>>> +		dev_err(dev, "Failed to force suspend: %d\n", ret);
>>>>
>>>> suggestion: since this is going to be fairly generic code
>>>> used by multiple devices, it'd be useful to add a device
>>>> identifier or string to the error log, no?
>>>
>>> Doesn't the dev_err already do that, it prints the device name in
>>> the log?
>>
>> Yes but the device name could be confusing, not everyone
>> can figure out what "sdw:0:0:025d:0711:01:" means
> 
> Personally I think if you are interfacing with these things you
> need to be able to interpret that anyway, since it will affect
> things like finding things in debugfs or sysfs as well.
> 
> However, if we do want to update the error messages to include
> some additional identifiers that should really be done for the
> whole class driver. So it would make more sense to do as a
> separate patch chain, rather than as part of this suspend chain.

Yes agreed, my suggestion was for future work.
The main thing was that for a class driver it's a bit odd that all the messages refer to the manufacturer and device ID. The two-level device structure will become even more confusing...