Re: [PATCH v2 1/4] ASoC: SDCA: Add SDCA IRQ enable/disable helpers

[Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>]

only a couple of nit-picks below:

> +/**
> + * sdca_irq_enable_early - Re-enable early SDCA IRQs for a given function
> + * @function: Pointer to the SDCA Function.
> + * @info: Pointer to the SDCA interrupt info for this device.
> + */
> +void sdca_irq_enable_early(struct sdca_function_data *function,
> +			   struct sdca_interrupt_info *info)
> +{
> +	irq_enable_flags(function, info, true);
> +}
> +EXPORT_SYMBOL_NS_GPL(sdca_irq_enable_early, "SND_SOC_SDCA");
> +
> +/**
> + * sdca_irq_enable_early - Re-enable SDCA IRQs for a given function

copy-paste from above making this kernel-doc description incorrect.

> + * @function: Pointer to the SDCA Function.
> + * @info: Pointer to the SDCA interrupt info for this device.
> + */
> +void sdca_irq_enable(struct sdca_function_data *function,
> +		     struct sdca_interrupt_info *info)
> +{
> +	irq_enable_flags(function, info, false);
> +}
> +EXPORT_SYMBOL_NS_GPL(sdca_irq_enable, "SND_SOC_SDCA");
> +
> +/**
> + * sdca_irq_disable - Disable SDCA IRQs for a given function
> + * @function: Pointer to the SDCA Function.
> + * @info: Pointer to the SDCA interrupt info for this device.
> + */
> +void sdca_irq_disable(struct sdca_function_data *function,
> +		      struct sdca_interrupt_info *info)

maybe explain why we have an _early version for enable but not a _late for disable?

> +{
> +	struct sdca_interrupt *interrupt;
> +	int i;
> +
> +	for (i = 0; i < SDCA_MAX_INTERRUPTS; i++) {
> +		interrupt = &info->irqs[i];
> +
> +		if (!interrupt || interrupt->function != function)
> +			continue;
> +
> +		disable_irq(interrupt->irq);
> +	}
> +}
> +EXPORT_SYMBOL_NS_GPL(sdca_irq_disable, "SND_SOC_SDCA");