Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: Takashi Iwai <tiwai@suse.de>,
	Maciej Strozek <mstrozek@opensource.cirrus.com>,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	patches@opensource.cirrus.com, linux-sound@vger.kernel.org
Subject: Re: [PATCH] ASoC: cs42l43: Fix build error without CONFIG_PM
Date: Wed, 12 Mar 2025 16:37:31 +0100	[thread overview]
Message-ID: <871pv2z2dg.wl-tiwai@suse.de> (raw)
In-Reply-To: <a5cd97fd-dbb0-4438-adf2-e2f9283d771a@sirena.org.uk>

On Wed, 12 Mar 2025 16:34:04 +0100,
Mark Brown wrote:
> 
> On Wed, Mar 12, 2025 at 03:56:39PM +0100, Takashi Iwai wrote:
> > Put __maybe_unused to work around the build error without CONFIG_PM
> > or CONFIG_PM_SLEEP for the newly defined system suspend callback.
> 
> Reviewed-by: Mark Brown <broonie@kernel.org>
> 
> I'm kind of surprised none of the build bot people noticed this...

Would you just apply and send a new PR later?
I didn't merge your previous PR yet.


thanks,

Takashi

  reply	other threads:[~2025-03-12 15:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-12 14:56 [PATCH] ASoC: cs42l43: Fix build error without CONFIG_PM Takashi Iwai
2025-03-12 15:07 ` Takashi Iwai
2025-03-12 15:11   ` Takashi Iwai
2025-03-12 15:34 ` Mark Brown
2025-03-12 15:37   ` Takashi Iwai [this message]
2025-03-12 15:48 ` Charles Keepax
2025-03-12 15:55   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871pv2z2dg.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=mstrozek@opensource.cirrus.com \
    --cc=patches@opensource.cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox