Re: [PATCH] ASoC: cs42l43: Fix build error without CONFIG_PM

[Takashi Iwai <tiwai@suse.de>]

On Wed, 12 Mar 2025 16:48:21 +0100,
Charles Keepax wrote:
> 
> On Wed, Mar 12, 2025 at 03:56:39PM +0100, Takashi Iwai wrote:
> > Put __maybe_unused to work around the build error without CONFIG_PM
> > or CONFIG_PM_SLEEP for the newly defined system suspend callback.
> > 
> > Fixes: 164b7dd4546b ("ASoC: cs42l43: Add jack delay debounce after suspend")
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > ---
> >  sound/soc/codecs/cs42l43.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/sound/soc/codecs/cs42l43.c b/sound/soc/codecs/cs42l43.c
> > index d307b56a7f38..4c7a598f5e73 100644
> > --- a/sound/soc/codecs/cs42l43.c
> > +++ b/sound/soc/codecs/cs42l43.c
> > @@ -2402,7 +2402,7 @@ static int cs42l43_codec_runtime_resume(struct device *dev)
> >  	return 0;
> >  }
> >  
> > -static int cs42l43_codec_runtime_force_suspend(struct device *dev)
> > +static int __maybe_unused cs42l43_codec_runtime_force_suspend(struct device *dev)
> >  {
> >  	struct cs42l43_codec *priv = dev_get_drvdata(dev);
> 
> I believe this should already be fixed by this patch:
> 
> https://patch.msgid.link/20250305172738.3437513-1-arnd@kernel.org
> 
> Which is probably a better fix as well.

Ah that's the one I looked for.  Yes, SYSTEM_SLEEP_PM_OPS() is a
better choice.


thanks,

Takashi