Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Mark Brown <broonie@kernel.org>,
	Maciej Strozek <mstrozek@opensource.cirrus.com>,
	<patches@opensource.cirrus.com>, <linux-sound@vger.kernel.org>
Subject: Re: [PATCH] ASoC: cs42l43: Fix build error without CONFIG_PM
Date: Wed, 12 Mar 2025 15:48:21 +0000	[thread overview]
Message-ID: <Z9GsxY9xMUFGRB/x@opensource.cirrus.com> (raw)
In-Reply-To: <20250312145642.26646-1-tiwai@suse.de>

On Wed, Mar 12, 2025 at 03:56:39PM +0100, Takashi Iwai wrote:
> Put __maybe_unused to work around the build error without CONFIG_PM
> or CONFIG_PM_SLEEP for the newly defined system suspend callback.
> 
> Fixes: 164b7dd4546b ("ASoC: cs42l43: Add jack delay debounce after suspend")
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>  sound/soc/codecs/cs42l43.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/cs42l43.c b/sound/soc/codecs/cs42l43.c
> index d307b56a7f38..4c7a598f5e73 100644
> --- a/sound/soc/codecs/cs42l43.c
> +++ b/sound/soc/codecs/cs42l43.c
> @@ -2402,7 +2402,7 @@ static int cs42l43_codec_runtime_resume(struct device *dev)
>  	return 0;
>  }
>  
> -static int cs42l43_codec_runtime_force_suspend(struct device *dev)
> +static int __maybe_unused cs42l43_codec_runtime_force_suspend(struct device *dev)
>  {
>  	struct cs42l43_codec *priv = dev_get_drvdata(dev);

I believe this should already be fixed by this patch:

https://patch.msgid.link/20250305172738.3437513-1-arnd@kernel.org

Which is probably a better fix as well.

Thanks,
Charles

  parent reply	other threads:[~2025-03-12 15:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-12 14:56 [PATCH] ASoC: cs42l43: Fix build error without CONFIG_PM Takashi Iwai
2025-03-12 15:07 ` Takashi Iwai
2025-03-12 15:11   ` Takashi Iwai
2025-03-12 15:34 ` Mark Brown
2025-03-12 15:37   ` Takashi Iwai
2025-03-12 15:48 ` Charles Keepax [this message]
2025-03-12 15:55   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z9GsxY9xMUFGRB/x@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=broonie@kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=mstrozek@opensource.cirrus.com \
    --cc=patches@opensource.cirrus.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox