Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	lgirdwood@gmail.com, linux-sound@vger.kernel.org,
	patches@opensource.cirrus.com
Subject: Re: [PATCH] ASoC: cs42l43: Move shutter IRQ handling into a worker thread
Date: Wed, 31 Jul 2024 08:30:15 +0200	[thread overview]
Message-ID: <87ikwmoyyw.wl-tiwai@suse.de> (raw)
In-Reply-To: <c555e200-af4a-4b71-9e04-d03f3f10c8d7@sirena.org.uk>

On Wed, 31 Jul 2024 01:20:40 +0200,
Mark Brown wrote:
> 
> On Tue, Jul 30, 2024 at 11:47:48PM +0200, Jaroslav Kysela wrote:
> > On 30. 07. 24 16:44, Mark Brown wrote:
> 
> > > With some of these slower buses it's not immediately obvious that it's
> > > worth the bother of caching - the overhead of doing the lookup is
> > > negligable in the overall context of handling the interrupt.
> 
> > I don't buy that argument. We should always try to write an optimal code.
> > Every CPU tick counts.
> 
> So do the bytes of memory you'd use caching the pointers!

Adding two more works would be even more wastes, that's the beginning
of the discussion :)

The problem is the order of ASoC component initialization, though;
AFAIUC, the kcontrols aren't instantiated at the point of component
probe, hence you can't get kcontrol objects there.


Takashi

  reply	other threads:[~2024-07-31  6:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-29 15:59 [PATCH] ASoC: cs42l43: Move shutter IRQ handling into a worker thread Charles Keepax
2024-07-29 16:18 ` Takashi Iwai
2024-07-29 16:44   ` Charles Keepax
2024-07-29 19:30     ` Takashi Iwai
2024-07-30  8:43       ` Charles Keepax
2024-07-30 12:33         ` Takashi Iwai
2024-07-30 14:13           ` Jaroslav Kysela
2024-07-30 14:27             ` Takashi Iwai
2024-07-30 14:44             ` Mark Brown
2024-07-30 21:47               ` Jaroslav Kysela
2024-07-30 23:20                 ` Mark Brown
2024-07-31  6:30                   ` Takashi Iwai [this message]
2024-07-31  8:49                     ` Charles Keepax

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ikwmoyyw.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox