[PATCH] ALSA: hda/realtek: Add quirk for HP Elite Dragonfly Folio G3 speakers

[PATCH] ALSA: hda/realtek: Add quirk for HP Elite Dragonfly Folio G3 speakers

[Michael Diesen]

The HP Elite Dragonfly Folio G3 (PCI SSID 103c:8a05) has 4 CS35L41
amplifiers on SPI, identical to the non-Folio Dragonfly G3 (103c:8981).
Without this quirk the amps are never registered and speakers stay
silent.

I've been carrying this as a local out-of-tree patch and would like
to get it merged. Note there is a related, recently merged quirk for
a neighboring SSID on what appears to be a sibling board variant:

   0a10faad5ca5 ("ALSA: hda/realtek: add quirk for HP Dragonfly Folio
   G3 2-in-1", 103c:8a06), which uses the SPI4 + GPIO LED fixup
   variant rather than plain SPI4.

My hardware (103c:8a05, "HP Elite Dragonfly Folio G3", non-2-in-1
SKU) works correctly with the plain ALC245_FIXUP_CS35L41_SPI_4
fixup and does not need the GPIO LED handling. Happy to re-test
against SPI_4_HP_GPIO_LED if you think that's actually the more
correct fixup for this board too — let me know.

Signed-off-by: Michael Diesen <michael.diesen@posteo.de>
---
  sound/hda/codecs/realtek/alc269.c | 1 +
  1 file changed, 1 insertion(+)

--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -6817,6 +6817,7 @@
       SND_PCI_QUIRK(0x103c, 0x89d3, "HP EliteBook 645 G9 (MB 89D2)", 
ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
       SND_PCI_QUIRK(0x103c, 0x89da, "HP Spectre x360 14t-ea100", 
ALC245_FIXUP_HP_SPECTRE_X360_EU0XXX),
       SND_PCI_QUIRK(0x103c, 0x89e7, "HP Elite x2 G9", 
ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+     SND_PCI_QUIRK(0x103c, 0x8a05, "HP Elite Dragonfly Folio G3", 
ALC245_FIXUP_CS35L41_SPI_4),
       SND_PCI_QUIRK(0x103c, 0x8a0f, "HP Pavilion 14-ec1xxx", 
ALC287_FIXUP_HP_GPIO_LED),
       SND_PCI_QUIRK(0x103c, 0x8a1f, "HP Laptop 14s-dr5xxx", 
ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
       SND_PCI_QUIRK(0x103c, 0x8a20, "HP Laptop 15s-fq5xxx", 
ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),

---

Re: [PATCH] ALSA: hda/realtek: Add quirk for HP Elite Dragonfly Folio G3 speakers

[Takashi Iwai]

On Wed, 08 Jul 2026 22:04:31 +0200,
Michael Diesen wrote:
> 
> The HP Elite Dragonfly Folio G3 (PCI SSID 103c:8a05) has 4 CS35L41
> amplifiers on SPI, identical to the non-Folio Dragonfly G3 (103c:8981).
> Without this quirk the amps are never registered and speakers stay
> silent.
> 
> I've been carrying this as a local out-of-tree patch and would like
> to get it merged. Note there is a related, recently merged quirk for
> a neighboring SSID on what appears to be a sibling board variant:
> 
>   0a10faad5ca5 ("ALSA: hda/realtek: add quirk for HP Dragonfly Folio
>   G3 2-in-1", 103c:8a06), which uses the SPI4 + GPIO LED fixup
>   variant rather than plain SPI4.
> 
> My hardware (103c:8a05, "HP Elite Dragonfly Folio G3", non-2-in-1
> SKU) works correctly with the plain ALC245_FIXUP_CS35L41_SPI_4
> fixup and does not need the GPIO LED handling. Happy to re-test
> against SPI_4_HP_GPIO_LED if you think that's actually the more
> correct fixup for this board too ― let me know.
> 
> Signed-off-by: Michael Diesen <michael.diesen@posteo.de>
> ---
>  sound/hda/codecs/realtek/alc269.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -6817,6 +6817,7 @@
>       SND_PCI_QUIRK(0x103c, 0x89d3, "HP EliteBook 645 G9 (MB 89D2)",
> ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
>       SND_PCI_QUIRK(0x103c, 0x89da, "HP Spectre x360 14t-ea100",
> ALC245_FIXUP_HP_SPECTRE_X360_EU0XXX),
>       SND_PCI_QUIRK(0x103c, 0x89e7, "HP Elite x2 G9",
> ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> +     SND_PCI_QUIRK(0x103c, 0x8a05, "HP Elite Dragonfly Folio G3",
> ALC245_FIXUP_CS35L41_SPI_4),
>       SND_PCI_QUIRK(0x103c, 0x8a0f, "HP Pavilion 14-ec1xxx",
> ALC287_FIXUP_HP_GPIO_LED),
>       SND_PCI_QUIRK(0x103c, 0x8a1f, "HP Laptop 14s-dr5xxx",
> ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
>       SND_PCI_QUIRK(0x103c, 0x8a20, "HP Laptop 15s-fq5xxx",
> ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),

The patch can't be applied cleanly via git-am, unfortunately, likely
because your mailer broke the space and lines.

Please fix your mailer setup and resubmit.
At best, try to send to yourself and test whether you can apply it via
git-am before the resubmission.


thanks,

Takashi

[PATCH v2] ALSA: hda/realtek: Add quirk for HP Dragonfly Folio G3 2-in-1 (103c:8a05)

[Michael Diesen]

The HP Dragonfly Folio G3 2-in-1 also ships with PCI SSID 103c:8a05.
On this unit the ALC245 codec reports subsystem id 103c:8a06 - the SSID
that is already covered by commit 0a10faad5ca5 ("ALSA: hda/realtek: add
quirk for HP Dragonfly Folio G3 2-in-1") - while the PCI SSID that
SND_PCI_QUIRK matches against is 103c:8a05:

  snd_hda_codec_alc269 ehdaudio0D0: ALC245: picked fixup for PCI SSID 103c:8a05
  cs35l41-hda spi1-CSC3551:00-cs35l41-hda.0: CS35L41 Bound - SSID: 103C8A06

The existing entry therefore never applies here, the four CS35L41
amplifiers on SPI are not registered and the internal speakers stay
silent.

Add the same fixup that the 8a06 entry uses: the four amplifiers bind
and the speaker mute LED (codec GPIO 0x04) works.

Signed-off-by: Michael Diesen <michael.diesen@posteo.de>
---
v2:
 - Resend using git send-email. v1 was mangled by my mail client (tabs
   converted to spaces, long context lines soft-wrapped) so it could not
   be applied with git am. Sorry for the noise, and thanks for the
   pointer - I tested this one by mailing it to myself and applying it
   with git am before sending.
 - Use ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED instead of plain
   ALC245_FIXUP_CS35L41_SPI_4. In v1 I claimed this was a non-2-in-1 SKU
   that does not need the LED handling. That was wrong: DMI reports the
   machine as "HP Dragonfly Folio G3 2-in-1", i.e. the same model as the
   8a06 entry, and the speaker mute LED stayed dark with plain SPI_4.
 - Name the entry identically to the 8a06 one, as it is the same machine
   with a different PCI SSID.

On the mic-mute LED: alc285_fixup_hp_gpio_led() also drives GPIO 0x01 as
mic-mute LED. That LED does not respond on this unit. Poking the codec
GPIOs directly with hda-verb shows 0x04 toggling the speaker mute LED,
while neither 0x01 nor 0x02 has any effect, so the mic-mute LED does not
appear to be wired to the codec here. It does not work without the quirk
either, so this is no regression, and it matches what the 8a06 entry
already does - hence I kept the shared fixup instead of adding a new one.

 sound/hda/codecs/realtek/alc269.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index b22564f..ec6724e 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -7160,6 +7160,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x89d3, "HP EliteBook 645 G9 (MB 89D2)", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
 	SND_PCI_QUIRK(0x103c, 0x89da, "HP Spectre x360 14t-ea100", ALC245_FIXUP_HP_SPECTRE_X360_EU0XXX),
 	SND_PCI_QUIRK(0x103c, 0x89e7, "HP Elite x2 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+	SND_PCI_QUIRK(0x103c, 0x8a05, "HP Dragonfly Folio G3 2-in-1", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8a06, "HP Dragonfly Folio G3 2-in-1", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8a0f, "HP Pavilion 14-ec1xxx", ALC287_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8a1b, "HP 255 15.6 inch G9 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
-- 
2.54.0

Re: [PATCH v2] ALSA: hda/realtek: Add quirk for HP Dragonfly Folio G3 2-in-1 (103c:8a05)

[Takashi Iwai]

On Mon, 27 Jul 2026 11:19:21 +0200,
Michael Diesen wrote:
> 
> The HP Dragonfly Folio G3 2-in-1 also ships with PCI SSID 103c:8a05.
> On this unit the ALC245 codec reports subsystem id 103c:8a06 - the SSID
> that is already covered by commit 0a10faad5ca5 ("ALSA: hda/realtek: add
> quirk for HP Dragonfly Folio G3 2-in-1") - while the PCI SSID that
> SND_PCI_QUIRK matches against is 103c:8a05:
> 
>   snd_hda_codec_alc269 ehdaudio0D0: ALC245: picked fixup for PCI SSID 103c:8a05
>   cs35l41-hda spi1-CSC3551:00-cs35l41-hda.0: CS35L41 Bound - SSID: 103C8A06
> 
> The existing entry therefore never applies here, the four CS35L41
> amplifiers on SPI are not registered and the internal speakers stay
> silent.
> 
> Add the same fixup that the 8a06 entry uses: the four amplifiers bind
> and the speaker mute LED (codec GPIO 0x04) works.
> 
> Signed-off-by: Michael Diesen <michael.diesen@posteo.de>
> ---
> v2:
>  - Resend using git send-email. v1 was mangled by my mail client (tabs
>    converted to spaces, long context lines soft-wrapped) so it could not
>    be applied with git am. Sorry for the noise, and thanks for the
>    pointer - I tested this one by mailing it to myself and applying it
>    with git am before sending.
>  - Use ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED instead of plain
>    ALC245_FIXUP_CS35L41_SPI_4. In v1 I claimed this was a non-2-in-1 SKU
>    that does not need the LED handling. That was wrong: DMI reports the
>    machine as "HP Dragonfly Folio G3 2-in-1", i.e. the same model as the
>    8a06 entry, and the speaker mute LED stayed dark with plain SPI_4.
>  - Name the entry identically to the 8a06 one, as it is the same machine
>    with a different PCI SSID.
> 
> On the mic-mute LED: alc285_fixup_hp_gpio_led() also drives GPIO 0x01 as
> mic-mute LED. That LED does not respond on this unit. Poking the codec
> GPIOs directly with hda-verb shows 0x04 toggling the speaker mute LED,
> while neither 0x01 nor 0x02 has any effect, so the mic-mute LED does not
> appear to be wired to the codec here. It does not work without the quirk
> either, so this is no regression, and it matches what the 8a06 entry
> already does - hence I kept the shared fixup instead of adding a new one.

Thanks, applied now.


Takashi