From: Takashi Iwai <tiwai@suse.de>
To: Cezary Rojewski <cezary.rojewski@intel.com>
Cc: Takashi Iwai <tiwai@suse.de>, <tiwai@suse.com>,
<broonie@kernel.org>, <perex@perex.cz>, <amade@asmblr.net>,
<linux-sound@vger.kernel.org>
Subject: Re: [PATCH] ALSA: hda: Allow for codec model selection with module param
Date: Mon, 14 Sep 2026 18:44:49 +0200 [thread overview]
Message-ID: <87tsnrn5oe.wl-tiwai@suse.de> (raw)
In-Reply-To: <9e17f127-ecaa-407f-96ec-0993e9c1ee83@intel.com>
On Mon, 14 Sep 2026 18:29:19 +0200,
Cezary Rojewski wrote:
>
> On 9/14/2026 6:01 PM, Takashi Iwai wrote:
> > On Mon, 14 Sep 2026 12:22:53 +0200,
> > Cezary Rojewski wrote:
> >>
> >> Model selection allows for customization of codec behaviour and thus
> >> dealing with various problems on very specific configurations. The
> >> parameter already exists but is part of snd_hda_intel specifically.
> >> Non-Intel HDAudio controllers and DSP-capable drivers cannot benefit
> >> from it.
> >>
> >> The common place for all the bus drivers is snd_hda_codec. Add modelname
> >> parameter there and honor it when initializing codec->modelname field.
> >>
> >> Link: https://github.com/thesofproject/linux/issues/5683
> >> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
> >
> > The handling of the model option is a very long-standing PITA.
> > A few years ago, I proposed a change like:
> > https://mailman.alsa-project.org/pipermail/alsa-devel/2022-September/206631.html
> > but it didn't reach to agreement. So I'm not 100% sure whether adding
> > here is the best choice, either.
> Thank you for the link, Takashi.
>
> IMHO patch presented here addresses the feedback. I too prefer
> one-location-for-all approach. Also, I do believe having no option for
> specifying the model is worse than choosing either of the approaches for
> the model selection.
>
> snd_hda_codec module is *everywhere* and given the param is an array, it
> supports even very complicated scenarios when multiple HDAudio codecs
> are engaged.
The multi-codec is exactly the problem I've been seeing (of course in
addition to the lack of the option in ASoC HD-audio). You'll have to
be very careful how to pass the option, and it can be even fragile.
That's why I hesitated to take this...
thanks,
Takashi
next prev parent reply other threads:[~2026-09-14 16:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 10:22 [PATCH] ALSA: hda: Allow for codec model selection with module param Cezary Rojewski
2026-09-14 16:01 ` Takashi Iwai
2026-09-14 16:29 ` Cezary Rojewski
2026-09-14 16:44 ` Takashi Iwai [this message]
2026-09-14 17:58 ` Cezary Rojewski
2026-09-15 11:14 ` Takashi Iwai
2026-09-15 11:26 ` Cezary Rojewski
2026-09-15 16:02 ` Takashi Iwai
2026-09-16 8:29 ` Cezary Rojewski
2026-09-16 10:57 ` Takashi Iwai
2026-09-18 8:33 ` Cezary Rojewski
2026-09-28 11:02 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tsnrn5oe.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=amade@asmblr.net \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox