[PATCH] ALSA: hda/realtek: Add ALC235 support for headset mode

[PATCH] ALSA: hda/realtek: Add ALC235 support for headset mode

[Zeyu Li]

The ALC235 (0x10ec0235) is registered as the ALC255 codec variant in
patch_alc269(), but the headset mode functions were missing a case
for it, so the CTIA/OMTP jack type detection and routing never ran
on this codec. As a result, a plugged-in headset is detected (jack
presence works) but the microphone signal is never routed, leaving
the capture stream permanently silent.

Verified on an ASUS M5451GA laptop (HDA:10ec0235,10431814): with the
ALC255 coef sequence applied, the headset microphone works correctly.

Signed-off-by: Zeyu Li <13776528859@163.com>
---
 sound/hda/codecs/realtek/realtek.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/sound/hda/codecs/realtek/realtek.c b/sound/hda/codecs/realtek/realtek.c
index db365a746..bc5226fad 100644
--- a/sound/hda/codecs/realtek/realtek.c
+++ b/sound/hda/codecs/realtek/realtek.c
@@ -1292,6 +1292,7 @@ static void alc_headset_mode_unplugged(struct hda_codec *codec)
 	}
 
 	switch (codec->core.vendor_id) {
+	case 0x10ec0235:
 	case 0x10ec0255:
 		alc_process_coef_fw(codec, coef0255);
 		break;
@@ -1407,6 +1408,7 @@ static void alc_headset_mode_mic_in(struct hda_codec *codec, hda_nid_t hp_pin,
 	};
 
 	switch (codec->core.vendor_id) {
+	case 0x10ec0235:
 	case 0x10ec0255:
 		alc_write_coef_idx(codec, 0x45, 0xc489);
 		snd_hda_set_pin_ctl_cache(codec, hp_pin, 0);
@@ -1562,6 +1564,7 @@ static void alc_headset_mode_default(struct hda_codec *codec)
 		alc_process_coef_fw(codec, coef0225);
 		alc_hp_enable_unmute(codec, 75);
 		break;
+	case 0x10ec0235:
 	case 0x10ec0255:
 		alc_process_coef_fw(codec, coef0255);
 		break;
@@ -1663,6 +1666,7 @@ static void alc_headset_mode_ctia(struct hda_codec *codec)
 	};
 
 	switch (codec->core.vendor_id) {
+	case 0x10ec0235:
 	case 0x10ec0255:
 		alc_process_coef_fw(codec, coef0255);
 		break;
@@ -1780,6 +1784,7 @@ static void alc_headset_mode_omtp(struct hda_codec *codec)
 	};
 
 	switch (codec->core.vendor_id) {
+	case 0x10ec0235:
 	case 0x10ec0255:
 		alc_process_coef_fw(codec, coef0255);
 		break;
@@ -1881,6 +1886,7 @@ static void alc_determine_headset_type(struct hda_codec *codec)
 	}
 
 	switch (codec->core.vendor_id) {
+	case 0x10ec0235:
 	case 0x10ec0255:
 		alc_process_coef_fw(codec, coef0255);
 		msleep(300);
-- 
2.53.0

Re: [PATCH] ALSA: hda/realtek: Add ALC235 support for headset mode

[Takashi Iwai]

On Sat, 26 Sep 2026 15:58:00 +0200,
Zeyu Li wrote:
> 
> The ALC235 (0x10ec0235) is registered as the ALC255 codec variant in
> patch_alc269(), but the headset mode functions were missing a case
> for it, so the CTIA/OMTP jack type detection and routing never ran
> on this codec. As a result, a plugged-in headset is detected (jack
> presence works) but the microphone signal is never routed, leaving
> the capture stream permanently silent.
> 
> Verified on an ASUS M5451GA laptop (HDA:10ec0235,10431814): with the
> ALC255 coef sequence applied, the headset microphone works correctly.
> 
> Signed-off-by: Zeyu Li <13776528859@163.com>
> ---
>  sound/hda/codecs/realtek/realtek.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/sound/hda/codecs/realtek/realtek.c b/sound/hda/codecs/realtek/realtek.c
> index db365a746..bc5226fad 100644
> --- a/sound/hda/codecs/realtek/realtek.c
> +++ b/sound/hda/codecs/realtek/realtek.c
> @@ -1292,6 +1292,7 @@ static void alc_headset_mode_unplugged(struct hda_codec *codec)
>  	}
>  
>  	switch (codec->core.vendor_id) {
> +	case 0x10ec0235:
>  	case 0x10ec0255:
>  		alc_process_coef_fw(codec, coef0255);
>  		break;
> @@ -1407,6 +1408,7 @@ static void alc_headset_mode_mic_in(struct hda_codec *codec, hda_nid_t hp_pin,
>  	};
>  
>  	switch (codec->core.vendor_id) {
> +	case 0x10ec0235:
>  	case 0x10ec0255:
>  		alc_write_coef_idx(codec, 0x45, 0xc489);
>  		snd_hda_set_pin_ctl_cache(codec, hp_pin, 0);
> @@ -1562,6 +1564,7 @@ static void alc_headset_mode_default(struct hda_codec *codec)
>  		alc_process_coef_fw(codec, coef0225);
>  		alc_hp_enable_unmute(codec, 75);
>  		break;
> +	case 0x10ec0235:
>  	case 0x10ec0255:
>  		alc_process_coef_fw(codec, coef0255);
>  		break;
> @@ -1663,6 +1666,7 @@ static void alc_headset_mode_ctia(struct hda_codec *codec)
>  	};
>  
>  	switch (codec->core.vendor_id) {
> +	case 0x10ec0235:
>  	case 0x10ec0255:
>  		alc_process_coef_fw(codec, coef0255);
>  		break;
> @@ -1780,6 +1784,7 @@ static void alc_headset_mode_omtp(struct hda_codec *codec)
>  	};
>  
>  	switch (codec->core.vendor_id) {
> +	case 0x10ec0235:
>  	case 0x10ec0255:
>  		alc_process_coef_fw(codec, coef0255);
>  		break;
> @@ -1881,6 +1886,7 @@ static void alc_determine_headset_type(struct hda_codec *codec)
>  	}
>  
>  	switch (codec->core.vendor_id) {
> +	case 0x10ec0235:
>  	case 0x10ec0255:
>  		alc_process_coef_fw(codec, coef0255);
>  		msleep(300);

I'm not sure whether it's 100% safe to apply this, and I'd like to
hear from Realtek.

Kailang, could you check it?  Can ALC235 be fully compatible in this
manner?


thanks,

Takashi

Re: [PATCH] ALSA: hda/realtek: Add ALC235 support for headset mode

[Zeyu Li]

Hi Takashi,

Thanks for picking this up.

To confirm the test setup: this was verified on an ASUS M5451GA laptop
(codec HDA:10ec0235,10431814). Before the change, plugging in a CTIA
headset was detected by jack sense (mic presence and VREF bias were
set correctly), but the capture stream stayed permanently silent.
After applying the ALC255 coefficient sequence (COEF 0x45=0xd489,
0x1b=0x0c2b), the headset microphone captures audio correctly.

I'm happy to test any alternative coefficient values if Realtek
suggests a different sequence for the ALC235.

Best regards,
Zeyu Li

Re: [PATCH] ALSA: hda/realtek: Add ALC235 support for headset mode

[Takashi Iwai]

On Mon, 28 Sep 2026 16:12:00 +0200,
Zeyu Li wrote:
> 
> Hi Takashi,
> 
> Thanks for picking this up.
> 
> To confirm the test setup: this was verified on an ASUS M5451GA laptop
> (codec HDA:10ec0235,10431814). Before the change, plugging in a CTIA
> headset was detected by jack sense (mic presence and VREF bias were
> set correctly), but the capture stream stayed permanently silent.
> After applying the ALC255 coefficient sequence (COEF 0x45=0xd489,
> 0x1b=0x0c2b), the headset microphone captures audio correctly.
> 
> I'm happy to test any alternative coefficient values if Realtek
> suggests a different sequence for the ALC235.

I applied the patch now.


thanks,

Takashi

RE: [PATCH] ALSA: hda/realtek: Add ALC235 support for headset mode

[Kailang]

-----Original Message-----
From: Takashi Iwai <tiwai@suse.de> 
Sent: Monday, September 28, 2026 8:50 PM
To: Zeyu Li <13776528859@163.com>
Cc: linux-sound@vger.kernel.org; Takashi Iwai <tiwai@suse.com>; Jaroslav Kysela <perex@perex.cz>; Kailang <kailang@realtek.com>
Subject: Re: [PATCH] ALSA: hda/realtek: Add ALC235 support for headset mode


External mail : This email originated from outside the organization. Do not reply, click links, or open attachments unless you recognize the sender and know the content is safe.



On Sat, 26 Sep 2026 15:58:00 +0200,
Zeyu Li wrote:
>
> The ALC235 (0x10ec0235) is registered as the ALC255 codec variant in 
> patch_alc269(), but the headset mode functions were missing a case for 
> it, so the CTIA/OMTP jack type detection and routing never ran on this 
> codec. As a result, a plugged-in headset is detected (jack presence 
> works) but the microphone signal is never routed, leaving the capture 
> stream permanently silent.
>
> Verified on an ASUS M5451GA laptop (HDA:10ec0235,10431814): with the
> ALC255 coef sequence applied, the headset microphone works correctly.
>
> Signed-off-by: Zeyu Li <13776528859@163.com>
> ---
>  sound/hda/codecs/realtek/realtek.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/sound/hda/codecs/realtek/realtek.c 
> b/sound/hda/codecs/realtek/realtek.c
> index db365a746..bc5226fad 100644
> --- a/sound/hda/codecs/realtek/realtek.c
> +++ b/sound/hda/codecs/realtek/realtek.c
> @@ -1292,6 +1292,7 @@ static void alc_headset_mode_unplugged(struct hda_codec *codec)
>       }
>
>       switch (codec->core.vendor_id) {
> +     case 0x10ec0235:
>       case 0x10ec0255:
>               alc_process_coef_fw(codec, coef0255);
>               break;
> @@ -1407,6 +1408,7 @@ static void alc_headset_mode_mic_in(struct hda_codec *codec, hda_nid_t hp_pin,
>       };
>
>       switch (codec->core.vendor_id) {
> +     case 0x10ec0235:
>       case 0x10ec0255:
>               alc_write_coef_idx(codec, 0x45, 0xc489);
>               snd_hda_set_pin_ctl_cache(codec, hp_pin, 0); @@ -1562,6 
> +1564,7 @@ static void alc_headset_mode_default(struct hda_codec *codec)
>               alc_process_coef_fw(codec, coef0225);
>               alc_hp_enable_unmute(codec, 75);
>               break;
> +     case 0x10ec0235:
>       case 0x10ec0255:
>               alc_process_coef_fw(codec, coef0255);
>               break;
> @@ -1663,6 +1666,7 @@ static void alc_headset_mode_ctia(struct hda_codec *codec)
>       };
>
>       switch (codec->core.vendor_id) {
> +     case 0x10ec0235:
>       case 0x10ec0255:
>               alc_process_coef_fw(codec, coef0255);
>               break;
> @@ -1780,6 +1784,7 @@ static void alc_headset_mode_omtp(struct hda_codec *codec)
>       };
>
>       switch (codec->core.vendor_id) {
> +     case 0x10ec0235:
>       case 0x10ec0255:
>               alc_process_coef_fw(codec, coef0255);
>               break;
> @@ -1881,6 +1886,7 @@ static void alc_determine_headset_type(struct hda_codec *codec)
>       }
>
>       switch (codec->core.vendor_id) {
> +     case 0x10ec0235:
>       case 0x10ec0255:
>               alc_process_coef_fw(codec, coef0255);
>               msleep(300);

>I'm not sure whether it's 100% safe to apply this, and I'd like to hear from Realtek.

>Kailang, could you check it?  Can ALC235 be fully compatible in this manner?

Yes, it's compatible.

>thanks,

>Takashi