[PATCH] ASoC: wm8998: Add Kconfig prompt

[PATCH] ASoC: wm8998: Add Kconfig prompt

[André Apitzsch via B4 Relay]

From: André Apitzsch <git@apitzsch.eu>

Add tristate prompt to allow codec selection.

Signed-off-by: André Apitzsch <git@apitzsch.eu>
---
 sound/soc/codecs/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 40bb7a1d44bcfa4c386f2eba0f475efeeedf1bdb..9ecc4bb7f75ff9fce87970d2e46ace72444e55b4 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -2479,7 +2479,7 @@ config SND_SOC_WM8997
 	depends on MFD_WM8997 && MFD_ARIZONA
 
 config SND_SOC_WM8998
-	tristate
+	tristate "Wolfson Microelectronics WM8998 codec driver"
 	depends on MFD_WM8998 && MFD_ARIZONA
 
 config SND_SOC_WM9081

---
base-commit: 7e74f756f5f643148ca5537bf2fee6767e4b0ed9
change-id: 20250418-wm8998-defae73b3320

Best regards,
-- 
André Apitzsch <git@apitzsch.eu>

Re: [PATCH] ASoC: wm8998: Add Kconfig prompt

[Charles Keepax]

On Fri, Apr 18, 2025 at 10:22:04PM +0200, André Apitzsch via B4 Relay wrote:
> From: André Apitzsch <git@apitzsch.eu>
> 
> Add tristate prompt to allow codec selection.
> 
> Signed-off-by: André Apitzsch <git@apitzsch.eu>
> ---

Generally its good to say why one wants to make the symbol
selectable, usually its to use it with simple card, although at
least historically I think simple card struggled to handle the
required set_sysclk calls for these codecs.

But I have no objection to this being exported:

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles
>  sound/soc/codecs/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index 40bb7a1d44bcfa4c386f2eba0f475efeeedf1bdb..9ecc4bb7f75ff9fce87970d2e46ace72444e55b4 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -2479,7 +2479,7 @@ config SND_SOC_WM8997
>  	depends on MFD_WM8997 && MFD_ARIZONA
>  
>  config SND_SOC_WM8998
> -	tristate
> +	tristate "Wolfson Microelectronics WM8998 codec driver"
>  	depends on MFD_WM8998 && MFD_ARIZONA
>  
>  config SND_SOC_WM9081
> 
> ---
> base-commit: 7e74f756f5f643148ca5537bf2fee6767e4b0ed9
> change-id: 20250418-wm8998-defae73b3320
> 
> Best regards,
> -- 
> André Apitzsch <git@apitzsch.eu>
> 
> 
> 

Re: [PATCH] ASoC: wm8998: Add Kconfig prompt

[Richard Fitzgerald]

On 21/4/25 15:15, Charles Keepax wrote:
> On Fri, Apr 18, 2025 at 10:22:04PM +0200, André Apitzsch via B4 Relay wrote:
>> From: André Apitzsch <git@apitzsch.eu>
>>
>> Add tristate prompt to allow codec selection.
>>
>> Signed-off-by: André Apitzsch <git@apitzsch.eu>
>> ---
> 
> Generally its good to say why one wants to make the symbol
> selectable, usually its to use it with simple card, although at
> least historically I think simple card struggled to handle the
> required set_sysclk calls for these codecs.
> 
> But I have no objection to this being exported:
> 
> Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> 
> Thanks,
> Charles

Yeah, I just checked simple-card and friends and I see no evidence that
it has a way to make the necessary calls to enable the clocks and PLL
on the WM8998.

Of course, the intended machine driver might not be simple/audio-graph
so that might not be a problem. Though a more specific machine driver
could simply select the codec driver it uses.

This is why it helps to say why you need this change.

Re: [PATCH] ASoC: wm8998: Add Kconfig prompt

[André Apitzsch]

Am Mittwoch, dem 23.04.2025 um 12:09 +0100 schrieb Richard Fitzgerald:
> On 21/4/25 15:15, Charles Keepax wrote:
> > On Fri, Apr 18, 2025 at 10:22:04PM +0200, André Apitzsch via B4
> > Relay wrote:
> > > From: André Apitzsch <git@apitzsch.eu>
> > > 
> > > Add tristate prompt to allow codec selection.
> > > 
> > > Signed-off-by: André Apitzsch <git@apitzsch.eu>
> > > ---
> > 
> > Generally its good to say why one wants to make the symbol
> > selectable, usually its to use it with simple card, although at
> > least historically I think simple card struggled to handle the
> > required set_sysclk calls for these codecs.
> > 
> > But I have no objection to this being exported:
> > 
> > Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> > 
> > Thanks,
> > Charles
> 
> Yeah, I just checked simple-card and friends and I see no evidence
> that it has a way to make the necessary calls to enable the clocks
> and PLL on the WM8998.
> 
> Of course, the intended machine driver might not be simple/audio-
> graph so that might not be a problem. Though a more specific machine
> driver could simply select the codec driver it uses.
> 
> This is why it helps to say why you need this change.

Hi,

the WM8998 is used by the BQ Aquaris M5 [1]. I forgot to mention it in
the commit message.

Best regards,
André


[1] https://wiki.postmarketos.org/wiki/BQ_Aquaris_M5_(bq-piccolo)

Re: [PATCH] ASoC: wm8998: Add Kconfig prompt

[Mark Brown]

On Fri, 18 Apr 2025 22:22:04 +0200, André Apitzsch wrote:
> Add tristate prompt to allow codec selection.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: wm8998: Add Kconfig prompt
      commit: 9ef24511d29f0300fc7e9d4a5ea38d78e9eef73e

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark