From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Bui Duc Phuc <phucduc.bui@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
"Peter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
<linux-sound@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
"Liam Girdwood" <liam.r.girdwood@linux.intel.com>
Subject: Re: [PATCH v3 5/5] ASoC: Intel: atom: Use guard() for locking
Date: Wed, 24 Jun 2026 10:54:37 +0200 [thread overview]
Message-ID: <ad96abd2-dd6b-4fdd-8033-bda4e1389884@intel.com> (raw)
In-Reply-To: <CAABR9nEWAcwTBet022zyDJPFVc55q4xZR7y8HNzc_x3WeCPtRA@mail.gmail.com>
On 6/24/2026 10:07 AM, Bui Duc Phuc wrote:
> Thanks for the review.
>
>>> Clean up the code using guard() for spin & mutex locks.
>>> Merely code refactoring, and no behavior change.
>>
>> The change looks good - just dropping by to mention that the cleanup.h
>> is missing everywhere : )
>
> I noticed that both spinlock.h and mutex.h already pull in cleanup.h,
> so the guard()/scoped_guard() macros are available without an explicit include.
> Could you clarify the reasoning for adding #include <linux/cleanup.h>
> explicitly here?
Follow the include-what-you-use (IWYU) approach. While the approach
could be tailored per-header, in general it makes any future job of
cleaning up the headers easier.
next prev parent reply other threads:[~2026-06-24 8:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 10:57 [PATCH v3 0/5] ASoC: Intel: Convert locking to guard()/scoped_guard() phucduc.bui
2026-06-23 10:57 ` [PATCH v3 1/5] ASoC: intel: sst-mfld-platform-pcm: Use __free(kfree) for stream pointer phucduc.bui
2026-06-23 19:35 ` Cezary Rojewski
2026-06-24 3:01 ` Bui Duc Phuc
2026-06-25 10:54 ` Bui Duc Phuc
2026-06-25 19:27 ` Cezary Rojewski
2026-06-26 1:59 ` Bui Duc Phuc
2026-06-23 10:57 ` [PATCH v3 2/5] ASoC: Intel: avs: Use guard() for locking phucduc.bui
2026-06-23 19:46 ` Cezary Rojewski
2026-06-24 9:52 ` Bui Duc Phuc
2026-06-23 10:57 ` [PATCH v3 3/5] ASoC: Intel: avs: Use scoped_guard() for scoped locking phucduc.bui
2026-06-23 10:57 ` [PATCH v3 4/5] ASoC: Intel: atom: " phucduc.bui
2026-06-23 10:57 ` [PATCH v3 5/5] ASoC: Intel: atom: Use guard() for locking phucduc.bui
2026-06-23 19:56 ` Cezary Rojewski
2026-06-24 8:07 ` Bui Duc Phuc
2026-06-24 8:54 ` Cezary Rojewski [this message]
2026-06-24 9:49 ` Bui Duc Phuc
2026-06-23 19:55 ` [PATCH v3 0/5] ASoC: Intel: Convert locking to guard()/scoped_guard() Cezary Rojewski
2026-06-24 3:13 ` Bui Duc Phuc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad96abd2-dd6b-4fdd-8033-bda4e1389884@intel.com \
--to=cezary.rojewski@intel.com \
--cc=broonie@kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=phucduc.bui@gmail.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox