From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Bui Duc Phuc <phucduc.bui@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
"Peter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
<linux-sound@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
"Liam Girdwood" <liam.r.girdwood@linux.intel.com>
Subject: Re: [PATCH v3 1/5] ASoC: intel: sst-mfld-platform-pcm: Use __free(kfree) for stream pointer
Date: Thu, 25 Jun 2026 21:27:02 +0200 [thread overview]
Message-ID: <b5692a55-40be-48a7-ba51-9c2ebe40a846@intel.com> (raw)
In-Reply-To: <CAABR9nGZjz+VZJOJBB_BF72iYQtCs3Fvc_zskaHF8DPFodzX8w@mail.gmail.com>
On 6/25/2026 12:54 PM, Bui Duc Phuc wrote:
> Hi Cezary,
...
> After re-reading the cleanup.h guidelines,
> I think I was mistaken about suggesting an ordering between the
> __free() and guard() patches.
> Sorry for the confusion.
> Since both conversions are part of the same goto-to-scope-cleanup transition,
> combining them into a single patch seems more appropriate.
> That said, I'm happy to follow your preference.
> Would you prefer a single patch or two separate patches?
Hi Phuc,
Thank you for revisiting your take. In regard to your question, I'd
prefer separating __free() from locking.
As a sidenote: even if that my take from technical perspective would be
a complete miss, the commit message should plainly state: a preparation
step for upcoming locking changes. With such statement, a maintainer is
aware that there is more to the change than just pointers cleanup and
placing it at the front is intentional.
Kind regards,
Czarek
next prev parent reply other threads:[~2026-06-25 19:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 10:57 [PATCH v3 0/5] ASoC: Intel: Convert locking to guard()/scoped_guard() phucduc.bui
2026-06-23 10:57 ` [PATCH v3 1/5] ASoC: intel: sst-mfld-platform-pcm: Use __free(kfree) for stream pointer phucduc.bui
2026-06-23 19:35 ` Cezary Rojewski
2026-06-24 3:01 ` Bui Duc Phuc
2026-06-25 10:54 ` Bui Duc Phuc
2026-06-25 19:27 ` Cezary Rojewski [this message]
2026-06-26 1:59 ` Bui Duc Phuc
2026-06-23 10:57 ` [PATCH v3 2/5] ASoC: Intel: avs: Use guard() for locking phucduc.bui
2026-06-23 19:46 ` Cezary Rojewski
2026-06-24 9:52 ` Bui Duc Phuc
2026-06-23 10:57 ` [PATCH v3 3/5] ASoC: Intel: avs: Use scoped_guard() for scoped locking phucduc.bui
2026-06-23 10:57 ` [PATCH v3 4/5] ASoC: Intel: atom: " phucduc.bui
2026-06-23 10:57 ` [PATCH v3 5/5] ASoC: Intel: atom: Use guard() for locking phucduc.bui
2026-06-23 19:56 ` Cezary Rojewski
2026-06-24 8:07 ` Bui Duc Phuc
2026-06-24 8:54 ` Cezary Rojewski
2026-06-24 9:49 ` Bui Duc Phuc
2026-06-23 19:55 ` [PATCH v3 0/5] ASoC: Intel: Convert locking to guard()/scoped_guard() Cezary Rojewski
2026-06-24 3:13 ` Bui Duc Phuc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5692a55-40be-48a7-ba51-9c2ebe40a846@intel.com \
--to=cezary.rojewski@intel.com \
--cc=broonie@kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=phucduc.bui@gmail.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox