Linux Sound subsystem development
 help / color / mirror / Atom feed
* [PATCH] ASoC: amd: yc: Add quirk for HP 200 G2a 16
@ 2026-01-29  6:50 Dirk Su
  2026-01-29 19:36 ` Mario Limonciello
  2026-02-03 12:05 ` Mark Brown
  0 siblings, 2 replies; 4+ messages in thread
From: Dirk Su @ 2026-01-29  6:50 UTC (permalink / raw)
  Cc: dirk.su, Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
	Lane Odenbach, Oliver Schramm, Adam Queler, Mario Limonciello,
	Gabriel Santese, Raven Black, Radhi Bajahaw, Alexandru Andries,
	Talhah Peerbhai, meowmeowbeanz, Yuzuru10, keenplify,
	Syed Saba kareem, linux-sound, linux-kernel

Fix the missing mic on HP 200 G2a 16 by adding quirk with the
board ID 8EE4

Signed-off-by: Dirk Su <dirk.su@canonical.com>
---
 sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index 0294177acc663..500b4fda0581f 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -633,6 +633,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "8BD6"),
 		}
 	},
+	{
+		.driver_data = &acp6x_card,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "HP"),
+			DMI_MATCH(DMI_BOARD_NAME, "8EE4"),
+		}
+	},
 	{
 		.driver_data = &acp6x_card,
 		.matches = {
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: amd: yc: Add quirk for HP 200 G2a 16
  2026-01-29  6:50 [PATCH] ASoC: amd: yc: Add quirk for HP 200 G2a 16 Dirk Su
@ 2026-01-29 19:36 ` Mario Limonciello
       [not found]   ` <CANJZD57huXXBuUiq=nJZ_WmucCkFv4vKHLUdXSmTvokjTadz6Q@mail.gmail.com>
  2026-02-03 12:05 ` Mark Brown
  1 sibling, 1 reply; 4+ messages in thread
From: Mario Limonciello @ 2026-01-29 19:36 UTC (permalink / raw)
  To: Dirk Su
  Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
	Lane Odenbach, Oliver Schramm, Adam Queler, Gabriel Santese,
	Raven Black, Radhi Bajahaw, Alexandru Andries, Talhah Peerbhai,
	meowmeowbeanz, Yuzuru10, keenplify, Syed Saba kareem, linux-sound,
	linux-kernel

On 1/29/26 12:50 AM, Dirk Su wrote:
> Fix the missing mic on HP 200 G2a 16 by adding quirk with the
> board ID 8EE4
> 
> Signed-off-by: Dirk Su <dirk.su@canonical.com>

Is this a production hardware and firmware?

If so this patch makes sense.

If it's not, can you please explore adding the _DSD entry 
"AcpDmicConnected".

> ---
>   sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
> index 0294177acc663..500b4fda0581f 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -633,6 +633,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
>   			DMI_MATCH(DMI_BOARD_NAME, "8BD6"),
>   		}
>   	},
> +	{
> +		.driver_data = &acp6x_card,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "HP"),
> +			DMI_MATCH(DMI_BOARD_NAME, "8EE4"),
> +		}
> +	},
>   	{
>   		.driver_data = &acp6x_card,
>   		.matches = {


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: amd: yc: Add quirk for HP 200 G2a 16
       [not found]   ` <CANJZD57huXXBuUiq=nJZ_WmucCkFv4vKHLUdXSmTvokjTadz6Q@mail.gmail.com>
@ 2026-01-30 14:37     ` Mario Limonciello
  0 siblings, 0 replies; 4+ messages in thread
From: Mario Limonciello @ 2026-01-30 14:37 UTC (permalink / raw)
  To: Dirk Su
  Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
	Lane Odenbach, Oliver Schramm, Adam Queler, Gabriel Santese,
	Raven Black, Radhi Bajahaw, Alexandru Andries, Talhah Peerbhai,
	meowmeowbeanz, Yuzuru10, keenplify, Syed Saba kareem, linux-sound,
	linux-kernel

On 1/29/26 9:26 PM, Dirk Su wrote:
> H Mario,
> 
> Thanks for the reply.
> This is a old generation CPU (AMD Athlon Gold 20, family:23, model:160).
> Anson@AMD suggest us using the quirk to fix the issue.

Old generation CPU but new platform?  Old generation CPU and old 
pre-production platform?

A quirk *may* be the right solution, but if this is there is still an 
opportunity to fix the platform firmware that is my preference.  You let 
me know based upon how far along it is.

> 
> Regards,
> Dirk
> 
> Mario Limonciello <mario.limonciello@amd.com 
> <mailto:mario.limonciello@amd.com>> 於 2026年1月30日週五 上午3:36寫道:
> 
>     On 1/29/26 12:50 AM, Dirk Su wrote:
>      > Fix the missing mic on HP 200 G2a 16 by adding quirk with the
>      > board ID 8EE4
>      >
>      > Signed-off-by: Dirk Su <dirk.su@canonical.com
>     <mailto:dirk.su@canonical.com>>
> 
>     Is this a production hardware and firmware?
> 
>     If so this patch makes sense.
> 
>     If it's not, can you please explore adding the _DSD entry
>     "AcpDmicConnected".
> 
>      > ---
>      >   sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
>      >   1 file changed, 7 insertions(+)
>      >
>      > diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/
>     acp6x-mach.c
>      > index 0294177acc663..500b4fda0581f 100644
>      > --- a/sound/soc/amd/yc/acp6x-mach.c
>      > +++ b/sound/soc/amd/yc/acp6x-mach.c
>      > @@ -633,6 +633,13 @@ static const struct dmi_system_id
>     yc_acp_quirk_table[] = {
>      >                       DMI_MATCH(DMI_BOARD_NAME, "8BD6"),
>      >               }
>      >       },
>      > +     {
>      > +             .driver_data = &acp6x_card,
>      > +             .matches = {
>      > +                     DMI_MATCH(DMI_BOARD_VENDOR, "HP"),
>      > +                     DMI_MATCH(DMI_BOARD_NAME, "8EE4"),
>      > +             }
>      > +     },
>      >       {
>      >               .driver_data = &acp6x_card,
>      >               .matches = {
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: amd: yc: Add quirk for HP 200 G2a 16
  2026-01-29  6:50 [PATCH] ASoC: amd: yc: Add quirk for HP 200 G2a 16 Dirk Su
  2026-01-29 19:36 ` Mario Limonciello
@ 2026-02-03 12:05 ` Mark Brown
  1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2026-02-03 12:05 UTC (permalink / raw)
  To: Dirk Su
  Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Lane Odenbach,
	Oliver Schramm, Adam Queler, Mario Limonciello, Gabriel Santese,
	Raven Black, Radhi Bajahaw, Alexandru Andries, Talhah Peerbhai,
	meowmeowbeanz, Yuzuru10, keenplify, Syed Saba kareem, linux-sound,
	linux-kernel

On Thu, 29 Jan 2026 14:50:19 +0800, Dirk Su wrote:
> Fix the missing mic on HP 200 G2a 16 by adding quirk with the
> board ID 8EE4
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: amd: yc: Add quirk for HP 200 G2a 16
      commit: 611c7d2262d5645118e0b3a9a88475d35a8366f2

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-02-03 12:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-29  6:50 [PATCH] ASoC: amd: yc: Add quirk for HP 200 G2a 16 Dirk Su
2026-01-29 19:36 ` Mario Limonciello
     [not found]   ` <CANJZD57huXXBuUiq=nJZ_WmucCkFv4vKHLUdXSmTvokjTadz6Q@mail.gmail.com>
2026-01-30 14:37     ` Mario Limonciello
2026-02-03 12:05 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox