* [PATCH] compile-i386: Use SPARSE_VERSION instead of __DATE__
@ 2017-09-22 8:14 Uwe Kleine-König
2017-10-02 19:47 ` Luc Van Oostenryck
0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König @ 2017-09-22 8:14 UTC (permalink / raw)
To: linux-sparse
The compile date isn't very informative for a tool, the version is what really
matters. Additionally using __DATE__ makes the build unreprodicible.
Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
---
compile-i386.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/compile-i386.c b/compile-i386.c
index e4d3f27dd8a9..1cedcbda73d8 100644
--- a/compile-i386.c
+++ b/compile-i386.c
@@ -57,6 +57,7 @@
#include "target.h"
#include "compile.h"
#include "bitmap.h"
+#include "version.h"
struct textbuf {
unsigned int len; /* does NOT include terminating null */
@@ -691,7 +692,7 @@ void emit_unit_begin(const char *basename)
void emit_unit_end(void)
{
textbuf_emit(&unit_post_text);
- printf("\t.ident\t\"sparse silly x86 backend (built %s)\"\n", __DATE__);
+ printf("\t.ident\t\"sparse silly x86 backend (version %s)\"\n", SPARSE_VERSION);
}
/* conditionally switch sections */
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] compile-i386: Use SPARSE_VERSION instead of __DATE__
2017-09-22 8:14 [PATCH] compile-i386: Use SPARSE_VERSION instead of __DATE__ Uwe Kleine-König
@ 2017-10-02 19:47 ` Luc Van Oostenryck
0 siblings, 0 replies; 2+ messages in thread
From: Luc Van Oostenryck @ 2017-10-02 19:47 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: linux-sparse
On Fri, Sep 22, 2017 at 10:14:10AM +0200, Uwe Kleine-König wrote:
> The compile date isn't very informative for a tool, the version is what really
> matters. Additionally using __DATE__ makes the build unreprodicible.
>
Acked-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-02 19:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-22 8:14 [PATCH] compile-i386: Use SPARSE_VERSION instead of __DATE__ Uwe Kleine-König
2017-10-02 19:47 ` Luc Van Oostenryck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox