From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: linux-sparse@vger.kernel.org
Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: [PATCH 2/8] fix error in bad conditional
Date: Fri, 2 Feb 2018 13:17:29 +0100 [thread overview]
Message-ID: <20180202121735.39621-3-luc.vanoostenryck@gmail.com> (raw)
In-Reply-To: <20180202121735.39621-1-luc.vanoostenryck@gmail.com>
Commit "b5867a33b (fix evaluation of a function or array symbol in conditionals)"
added a missing call to degenerate(epxr) but this must not be done
if the expression is erroneous.
fix this by bypassing the call to degenerate() if the ctype is NULL.
Fixes: b5867a33b62c04811784c6fc233c601a4f2b0841
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
evaluate.c | 4 +++-
validation/bad-type-twice0.c | 1 -
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/evaluate.c b/evaluate.c
index 402fa04af..027993983 100644
--- a/evaluate.c
+++ b/evaluate.c
@@ -894,7 +894,9 @@ static struct symbol *evaluate_conditional(struct expression *expr, int iterator
ctype = NULL;
}
}
- ctype = degenerate(expr);
+
+ if (ctype)
+ ctype = degenerate(expr);
return ctype;
}
diff --git a/validation/bad-type-twice0.c b/validation/bad-type-twice0.c
index 2dbc91b03..7a9073c52 100644
--- a/validation/bad-type-twice0.c
+++ b/validation/bad-type-twice0.c
@@ -5,7 +5,6 @@ static int foo(a)
/*
* check-name: bad-type-twice0
- * check-known-to-fail
*
* check-error-start
bad-type-twice0.c:3:16: error: incorrect type in conditional
--
2.16.0
next prev parent reply other threads:[~2018-02-02 12:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 12:17 [PATCH 0/8] avoid duplicated warnings Luc Van Oostenryck
2018-02-02 12:17 ` [PATCH 1/8] add testcases for duplicated warning about invalid types Luc Van Oostenryck
2018-02-02 12:17 ` Luc Van Oostenryck [this message]
2018-02-02 12:17 ` [PATCH 3/8] early return if null ctype in evaluate_conditional() Luc Van Oostenryck
2018-02-10 19:28 ` Christopher Li
2018-02-10 19:43 ` Luc Van Oostenryck
2018-02-02 12:17 ` [PATCH 4/8] add helper: valid_type() Luc Van Oostenryck
2018-02-10 19:38 ` Christopher Li
2018-02-10 19:51 ` Luc Van Oostenryck
2018-02-02 12:17 ` [PATCH 5/8] use valid_type to avoid to warn twice on conditionals Luc Van Oostenryck
2018-02-02 12:17 ` [PATCH 6/8] add helpers: valid_expr_type() & valid_subexpr_type() Luc Van Oostenryck
2018-02-02 12:17 ` [PATCH 7/8] do not report bad types twice Luc Van Oostenryck
2018-02-02 12:17 ` [PATCH 8/8] always evaluate both operands Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180202121735.39621-3-luc.vanoostenryck@gmail.com \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox