From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Christopher Li <sparse@chrisli.org>
Cc: Linux-Sparse <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH 3/8] early return if null ctype in evaluate_conditional()
Date: Sat, 10 Feb 2018 20:43:50 +0100 [thread overview]
Message-ID: <20180210194350.76pdd5sukyfvqqae@ltop.local> (raw)
In-Reply-To: <CANeU7QmA+2WQcZRbgG9bb_N8su1SH90U3JFyyntiyijAXJbCxQ@mail.gmail.com>
On Sat, Feb 10, 2018 at 11:28:44AM -0800, Christopher Li wrote:
> On Fri, Feb 2, 2018 at 4:17 AM, Luc Van Oostenryck
> <luc.vanoostenryck@gmail.com> wrote:
> > NB: no functional changes here.
> >
> This is not straightly necessary to re-indent a section of the code.
Not needed but it was the prupose of the patch so that one of the following
patches become very clear about the functional change it made.
It's a very good things to separate functional from non-functional changes.
-- Luc
next prev parent reply other threads:[~2018-02-10 19:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 12:17 [PATCH 0/8] avoid duplicated warnings Luc Van Oostenryck
2018-02-02 12:17 ` [PATCH 1/8] add testcases for duplicated warning about invalid types Luc Van Oostenryck
2018-02-02 12:17 ` [PATCH 2/8] fix error in bad conditional Luc Van Oostenryck
2018-02-02 12:17 ` [PATCH 3/8] early return if null ctype in evaluate_conditional() Luc Van Oostenryck
2018-02-10 19:28 ` Christopher Li
2018-02-10 19:43 ` Luc Van Oostenryck [this message]
2018-02-02 12:17 ` [PATCH 4/8] add helper: valid_type() Luc Van Oostenryck
2018-02-10 19:38 ` Christopher Li
2018-02-10 19:51 ` Luc Van Oostenryck
2018-02-02 12:17 ` [PATCH 5/8] use valid_type to avoid to warn twice on conditionals Luc Van Oostenryck
2018-02-02 12:17 ` [PATCH 6/8] add helpers: valid_expr_type() & valid_subexpr_type() Luc Van Oostenryck
2018-02-02 12:17 ` [PATCH 7/8] do not report bad types twice Luc Van Oostenryck
2018-02-02 12:17 ` [PATCH 8/8] always evaluate both operands Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180210194350.76pdd5sukyfvqqae@ltop.local \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox